From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BD2C32788 for ; Thu, 11 Oct 2018 11:13:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 169D32077C for ; Thu, 11 Oct 2018 11:13:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 169D32077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728342AbeJKSj5 (ORCPT ); Thu, 11 Oct 2018 14:39:57 -0400 Received: from foss.arm.com ([217.140.101.70]:35868 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727245AbeJKSj5 (ORCPT ); Thu, 11 Oct 2018 14:39:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B079D7A9; Thu, 11 Oct 2018 04:13:11 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BFEA73F5BC; Thu, 11 Oct 2018 04:13:08 -0700 (PDT) Date: Thu, 11 Oct 2018 12:13:06 +0100 From: Sudeep Holla To: "Raju P.L.S.S.S.N" Cc: andy.gross@linaro.org, david.brown@linaro.org, rjw@rjwysocki.net, ulf.hansson@linaro.org, khilman@kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, rnayak@codeaurora.org, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, sboyd@kernel.org, evgreen@chromium.org, dianders@chromium.org, mka@chromium.org, ilina@codeaurora.org Subject: Re: [PATCH RFC v1 4/8] drivers: qcom: cpu_pd: add cpu power domain support using genpd Message-ID: <20181011111306.GB32752@e107155-lin> References: <1539206455-29342-1-git-send-email-rplsssn@codeaurora.org> <1539206455-29342-5-git-send-email-rplsssn@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1539206455-29342-5-git-send-email-rplsssn@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 11, 2018 at 02:50:51AM +0530, Raju P.L.S.S.S.N wrote: > RPMH based targets require that the sleep and wake state request votes > be sent during system low power mode entry. The votes help reduce the > power consumption when the AP is not using them. The votes sent by the > clients are cached in RPMH controller and needs to be flushed when the > last cpu enters low power mode. So add cpu power domain using Linux > generic power domain infrastructure to perform necessary tasks as part > of domain power down. > You seem to have either randomly chosen just 3 patches from Lina/Ulf's CPU genpd series or this series doesn't entirely depend on it ? If latter, how does this work with PSCI CPU_SUSPEND operations ? And why this can be part of PSCI firmware implementation. Only PSCI firmware needs if RPMH votes need to be flushed or not. So, honestly I don't see the need for this in Linux. -- Regards, Sudeep