From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17284C6783C for ; Fri, 12 Oct 2018 09:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D97542087D for ; Fri, 12 Oct 2018 09:22:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D97542087D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728297AbeJLQxj (ORCPT ); Fri, 12 Oct 2018 12:53:39 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:48434 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728021AbeJLQxj (ORCPT ); Fri, 12 Oct 2018 12:53:39 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DFEDFF; Fri, 12 Oct 2018 02:22:09 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B0C5D3F5B7; Fri, 12 Oct 2018 02:22:09 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id E74691AE2DA4; Fri, 12 Oct 2018 10:22:09 +0100 (BST) Date: Fri, 12 Oct 2018 10:22:09 +0100 From: Will Deacon To: Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, longman@redhat.com, andrea.parri@amarulasolutions.com, tglx@linutronix.de, bigeasy@linutronix.de Subject: Re: [PATCH v2 4/4] locking/qspinlock, x86: Provide liveness guarantee Message-ID: <20181012092209.GE12289@arm.com> References: <20181003130257.156322446@infradead.org> <20181003130957.183726335@infradead.org> <20181010161257.GD17340@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181010161257.GD17340@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 10, 2018 at 05:12:57PM +0100, Will Deacon wrote: > On Wed, Oct 03, 2018 at 03:03:01PM +0200, Peter Zijlstra wrote: > > arch/x86/include/asm/qspinlock.h | 15 +++++++++++++++ > > kernel/locking/qspinlock.c | 16 +++++++++++++++- > > 2 files changed, 30 insertions(+), 1 deletion(-) > > I've failed to break this by thinking really hard, so I've updated Catalin's > TLA model to see if the tools are still happy. I'll get back to you once > they've finished chewing on it. The model is happy, so this doesn't introduce any "bad" SC behaviours. Reviewed-by: Will Deacon Will