From: Steven Rostedt <rostedt@goodmis.org>
To: Masanari Iida <standby24x7@gmail.com>
Cc: corbet@lwn.net, linux-kernel@vger.kernel.org,
mchehab+samsung@kernel.org,
Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: Re: [PATCH] docs: Fix typos in histogram.rst
Date: Fri, 12 Oct 2018 22:04:52 -0400 [thread overview]
Message-ID: <20181012220452.57d23a82@vmware.local.home> (raw)
In-Reply-To: <20181013013057.10677-1-standby24x7@gmail.com>
On Sat, 13 Oct 2018 10:30:57 +0900
Masanari Iida <standby24x7@gmail.com> wrote:
> This patch fixes some spelling typos.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
> Documentation/trace/histogram.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/trace/histogram.rst b/Documentation/trace/histogram.rst
> index 5ac724baea7d..7dda76503127 100644
> --- a/Documentation/trace/histogram.rst
> +++ b/Documentation/trace/histogram.rst
> @@ -1765,7 +1765,7 @@ For example, here's how a latency can be calculated::
> # echo 'hist:keys=pid,prio:ts0=common_timestamp ...' >> event1/trigger
> # echo 'hist:keys=next_pid:wakeup_lat=common_timestamp-$ts0 ...' >> event2/trigger
>
> -In the first line above, the event's timetamp is saved into the
> +In the first line above, the event's timestamp is saved into the
> variable ts0. In the next line, ts0 is subtracted from the second
> event's timestamp to produce the latency, which is then assigned into
> yet another variable, 'wakeup_lat'. The hist trigger below in turn
> @@ -1811,7 +1811,7 @@ the command that defined it with a '!'::
> /sys/kernel/debug/tracing/synthetic_events
>
> At this point, there isn't yet an actual 'wakeup_latency' event
> -instantiated in the event subsytem - for this to happen, a 'hist
> +instantiated in the event subsystem - for this to happen, a 'hist
The first two appear to show that Tom has a faulty 's' key ;-)
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> trigger action' needs to be instantiated and bound to actual fields
> and variables defined on other events (see Section 2.2.3 below on
> how that is done using hist trigger 'onmatch' action). Once that is
> @@ -1837,7 +1837,7 @@ output can be displayed by reading the event's 'hist' file.
> A hist trigger 'action' is a function that's executed whenever a
> histogram entry is added or updated.
>
> -The default 'action' if no special function is explicity specified is
> +The default 'action' if no special function is explicitly specified is
> as it always has been, to simply update the set of values associated
> with an entry. Some applications, however, may want to perform
> additional actions at that point, such as generate another event, or
next prev parent reply other threads:[~2018-10-13 2:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 1:30 [PATCH] docs: Fix typos in histogram.rst Masanari Iida
2018-10-13 1:35 ` Randy Dunlap
2018-10-13 2:04 ` Steven Rostedt [this message]
2018-10-18 18:33 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012220452.57d23a82@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=standby24x7@gmail.com \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox