Re: [PATCH v3 2/2] mmc: tmio: remove TMIO_MMC_HAVE_HIGH_REG flag

Wolfram Sang
2018-10-15T11:32:29Z

[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]

On Mon, Oct 15, 2018 at 12:28:12AM +0200, Wolfram Sang wrote:
> On Wed, Oct 10, 2018 at 12:51:32PM +0900, Masahiro Yamada wrote:
> > TMIO_MMC_HAVE_HIGH_REG is confusing due to its counter-intuitive name.
> >
> > All the TMIO MMC variants (TMIO MMC, Renesas SDHI, UniPhier SD) actually
> > have high registers. It is just that each of them implements its own
> > registers there. The original IP from Panasonic only defines registers
> > 0x00-0xff in the bus_shift=1 review. The register area above them is
> > platform-dependent.
> >
> > In fact, TMIO_MMC_HAVE_HIGH_REG is set only by tmio-mmc.c and used to
> > test the accessibility of CTL_SDIO_REGS. Because it is specific to
> > the TMIO MFD variant, the right thing to do is to move such registers
> > to tmio_mmc.c and delete the TMIO_MMC_HAVE_HIGH_REG flag.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Tested on R-Car H3 ES1.0 and ES2.0, M3N, and H2. No regressions. I
pulled the SD card out during transfer to ensure the reset function will
surely be called.

Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>