Re: [PATCH v13 00/12] livepatch: Atomic replace feature

Josh Poimboeuf
2018-10-18T13:34:42Z

On Mon, Oct 15, 2018 at 02:37:01PM +0200, Petr Mladek wrote:
> The atomic replace allows to create cumulative patches. They
> are useful when you maintain many livepatches and want to remove
> one that is lower on the stack. In addition it is very useful when
> more patches touch the same function and there are dependencies
> between them.
>
> Now, the question is if 13 is a lucky number. I hope so
> and that this version might get merged. Any feedback?
>
> Not only from Mirek, please ;-)
>
>
> Changes against v12:
>
> + Finish freeing the patch using workqueues to prevent
> deadlock against kobject code.
>
> + Check for valid pointers when initializing the dynamic
> lists objects and functions.
>
> + Mark klp_free_objects_dynamic() static.
>
> + Improved documentation and fixed typos

Other than the few comments I made, this is looking good to me. I'm
optimistic about v14. It's probably best to not merge a v13 anyway. ;-)
Thanks a lot for sticking with it.

--
Josh