From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javierm@redhat.com>,
linux-arm-kernel@lists.infradead.org, andy.shevchenko@gmail.com
Subject: Re: [PATCH 1/3] driver core: add probe_err log helper
Date: Tue, 16 Oct 2018 13:09:08 +0200 [thread overview]
Message-ID: <20181016110908.GA32581@kroah.com> (raw)
In-Reply-To: <20181016102715.GD7449@sirena.org.uk>
On Tue, Oct 16, 2018 at 11:27:15AM +0100, Mark Brown wrote:
> On Tue, Oct 16, 2018 at 09:22:42AM +0200, Andrzej Hajda wrote:
>
> > +int probe_err(const struct device *dev, int err, const char *fmt, ...)
> > +{
> > + struct va_format vaf;
> > + va_list args;
>
> ...
>
> > + return err;
> > +}
> > +
>
> This will need an EXPORT_SYMBOL for modules won't it?
EXPORT_SYMBOL_GPL() to be specific, as it is dealing with the driver
core.
thanks,
greg k-h
next prev parent reply other threads:[~2018-10-16 11:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181016072248eucas1p18943ce87e084797cd597afd4edb65a65@eucas1p1.samsung.com>
2018-10-16 7:22 ` [PATCH 0/3] driver core: add probe error check helper Andrzej Hajda
2018-10-16 7:22 ` [PATCH 1/3] driver core: add probe_err log helper Andrzej Hajda
2018-10-16 9:32 ` Javier Martinez Canillas
2018-10-16 10:27 ` Mark Brown
2018-10-16 11:09 ` Greg Kroah-Hartman [this message]
2018-10-16 11:01 ` Andy Shevchenko
2018-10-16 11:29 ` Andrzej Hajda
[not found] ` <605bd00e-ed0d-4259-bdc3-1784b2b3b16a@samsung.com>
2018-10-16 12:55 ` Andrzej Hajda
2018-10-16 13:55 ` Andy Shevchenko
2018-10-17 8:58 ` [PATCH v2 " Andrzej Hajda
2018-10-17 9:56 ` Mark Brown
2018-10-17 11:30 ` Andy Shevchenko
2018-10-17 11:49 ` Greg Kroah-Hartman
2018-10-17 11:29 ` [PATCH " Russell King - ARM Linux
2018-10-17 11:33 ` Andy Shevchenko
2018-10-17 13:22 ` [PATCH v3 1/4] " Andrzej Hajda
2018-10-18 1:45 ` [PATCH 1/3] " Joe Perches
2018-10-16 7:22 ` [PATCH 2/3] driver core: add deferring probe reason to devices_deferred property Andrzej Hajda
2018-10-16 9:25 ` Mark Brown
2018-10-16 9:47 ` Javier Martinez Canillas
2018-10-16 13:42 ` Andy Shevchenko
2018-10-17 8:59 ` [PATCH v2 " Andrzej Hajda
2018-10-17 11:35 ` Andy Shevchenko
2018-10-17 13:24 ` [PATCH v3 2/4] " Andrzej Hajda
2018-10-17 14:17 ` Andy Shevchenko
2018-10-18 6:49 ` [PATCH v4 2/3] " Andrzej Hajda
2018-10-16 7:22 ` [PATCH 3/3] drivers: use probe_err function in obvious cases Andrzej Hajda
2018-10-16 9:52 ` Javier Martinez Canillas
2018-10-16 13:51 ` Andy Shevchenko
2018-10-17 9:10 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016110908.GA32581@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=a.hajda@samsung.com \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=javierm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox