public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <tobin@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>
Cc: "Tobin C. Harding" <tobin@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 0/7] drivers: tty: Fix kernel-docs comments
Date: Wed, 17 Oct 2018 10:21:23 +1100	[thread overview]
Message-ID: <20181016232130.728-1-tobin@kernel.org> (raw)

Hi,

My first patch set using kernel.org email address.  I've been so careful
with this one I'm expecting some epic fail :)

This set is an attempt to clean up the kernel docs comments under
drivers/tty/.  I do not know what time in the kernel dev cycle would be
best for this set.  If now is not the time please do not hesitate to say
so and stop reading here.

I included a couple of whitespace patches to kick off with, in hindsight
these might be nothing more than code churn (if so I can remove them).

I had a real hard time breaking these changes up into separate patches.
This was mainly because I was super conscious that this set is
borderline trivial yet large enough to be a P in the A to review.  I
have reviewed these patches a bunch of times myself and am happy with
the result being as easy to review as I know how.  If there was anything
more I could have done please say.  Patch 3 and 7 are the two that are
most arduous to review.

Apart from the first two whitespace patches only comments are touched by
this set.  The set builds cleanly but does _not_ checkpatch cleanly -
there is a limit to the code churn I was willing to risk posting :)

Extra thanks to anyone who reviews this.  This set is super non-critical
so please only review at your leisure.

thanks,
Tobin.


Tobin C. Harding (7):
  tty: Fix whitespace before tab warnings
  tty: Remove trailing whitespace
  tty: Partially fix kernel-docs layout
  tty: Fix kernel-doc variable typos
  tty: Fix spacing between kernel-doc sections
  tty: Remove newline after function kernel-doc
  tty: Fix section format

 drivers/tty/amiserial.c                     |   62 +-
 drivers/tty/cyclades.c                      |    2 +-
 drivers/tty/ehv_bytechan.c                  |    2 +-
 drivers/tty/hvc/hvc_console.c               |    8 +-
 drivers/tty/hvc/hvc_iucv.c                  |   14 +-
 drivers/tty/hvc/hvc_xen.c                   |    2 +-
 drivers/tty/hvc/hvcs.c                      |    4 +-
 drivers/tty/ipwireless/tty.c                |    2 +-
 drivers/tty/isicom.c                        |    4 +-
 drivers/tty/mips_ejtag_fdc.c                |    4 +-
 drivers/tty/moxa.c                          |   38 +-
 drivers/tty/mxser.c                         |   14 +-
 drivers/tty/n_gsm.c                         |  754 +++++++-------
 drivers/tty/n_hdlc.c                        |  208 ++--
 drivers/tty/n_r3964.c                       |    6 +-
 drivers/tty/n_tracerouter.c                 |   18 +-
 drivers/tty/n_tracesink.c                   |   24 +-
 drivers/tty/n_tty.c                         |  688 ++++++-------
 drivers/tty/pty.c                           |  126 ++-
 drivers/tty/rocket.c                        |   78 +-
 drivers/tty/serdev/core.c                   |    2 +-
 drivers/tty/serial/21285.c                  |    2 +-
 drivers/tty/serial/8250/8250_core.c         |   72 +-
 drivers/tty/serial/8250/8250_dw.c           |    4 +-
 drivers/tty/serial/8250/8250_port.c         |   42 +-
 drivers/tty/serial/amba-pl010.c             |    2 +-
 drivers/tty/serial/amba-pl011.c             |   34 +-
 drivers/tty/serial/cpm_uart/cpm_uart_core.c |    8 +-
 drivers/tty/serial/earlycon.c               |   26 +-
 drivers/tty/serial/icom.c                   |    5 +-
 drivers/tty/serial/ifx6x60.c                |  387 ++++---
 drivers/tty/serial/ioc3_serial.c            |   73 +-
 drivers/tty/serial/ioc4_serial.c            |   85 +-
 drivers/tty/serial/ip22zilog.c              |    2 +-
 drivers/tty/serial/jsm/jsm_neo.c            |    2 +-
 drivers/tty/serial/kgdb_nmi.c               |    2 +-
 drivers/tty/serial/max3100.c                |    2 +-
 drivers/tty/serial/max310x.c                |    2 +-
 drivers/tty/serial/men_z135_uart.c          |    5 +-
 drivers/tty/serial/mux.c                    |   62 +-
 drivers/tty/serial/mxs-auart.c              |    2 +-
 drivers/tty/serial/pmac_zilog.c             |   62 +-
 drivers/tty/serial/pxa.c                    |   20 +-
 drivers/tty/serial/sa1100.c                 |    2 +-
 drivers/tty/serial/serial-tegra.c           |    4 +-
 drivers/tty/serial/serial_core.c            |  198 ++--
 drivers/tty/serial/serial_txx9.c            |   23 +-
 drivers/tty/serial/sn_console.c             |  105 +-
 drivers/tty/serial/sunsab.c                 |   16 +-
 drivers/tty/serial/sunsu.c                  |    8 +-
 drivers/tty/serial/sunzilog.c               |   10 +-
 drivers/tty/serial/uartlite.c               |   15 +-
 drivers/tty/serial/ucc_uart.c               |  134 +--
 drivers/tty/serial/vr41xx_siu.c             |    2 +-
 drivers/tty/serial/xilinx_uartps.c          |   71 +-
 drivers/tty/serial/zs.c                     |   12 +-
 drivers/tty/synclink.c                      | 1016 +++++++++----------
 drivers/tty/synclinkmp.c                    |   16 +-
 drivers/tty/sysrq.c                         |   34 +-
 drivers/tty/tty_audit.c                     |   39 +-
 drivers/tty/tty_baudrate.c                  |   77 +-
 drivers/tty/tty_buffer.c                    |  245 +++--
 drivers/tty/tty_io.c                        |  847 ++++++++--------
 drivers/tty/tty_ioctl.c                     |  224 ++--
 drivers/tty/tty_jobctrl.c                   |  141 ++-
 drivers/tty/tty_ldisc.c                     |  290 +++---
 drivers/tty/tty_port.c                      |  124 ++-
 drivers/tty/vt/consolemap.c                 |   84 +-
 drivers/tty/vt/keyboard.c                   |  165 +--
 drivers/tty/vt/selection.c                  |   40 +-
 drivers/tty/vt/vt.c                         |  138 ++-
 drivers/tty/vt/vt_ioctl.c                   |   70 +-
 72 files changed, 3454 insertions(+), 3657 deletions(-)

-- 
2.17.1


             reply	other threads:[~2018-10-16 23:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16 23:21 Tobin C. Harding [this message]
2018-10-16 23:21 ` [PATCH 1/7] tty: Fix whitespace before tab warnings Tobin C. Harding
2018-10-16 23:21 ` [PATCH 2/7] tty: Remove trailing whitespace Tobin C. Harding
2018-10-18  5:19   ` Greg Kroah-Hartman
2018-10-18  5:55     ` Tobin C. Harding
2018-10-16 23:21 ` [PATCH 3/7] tty: Partially fix kernel-docs layout Tobin C. Harding
2018-10-16 23:21 ` [PATCH 4/7] tty: Fix kernel-doc variable typos Tobin C. Harding
2018-10-16 23:21 ` [PATCH 5/7] tty: Fix spacing between kernel-doc sections Tobin C. Harding
2018-10-16 23:21 ` [PATCH 6/7] tty: Remove newline after function kernel-doc Tobin C. Harding
2018-10-16 23:21 ` [PATCH 7/7] tty: Fix section format Tobin C. Harding
2018-10-17  7:00 ` [PATCH 0/7] drivers: tty: Fix kernel-docs comments Geert Uytterhoeven
2018-10-17  7:29   ` Tobin C. Harding
2018-10-18  0:17   ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181016232130.728-1-tobin@kernel.org \
    --to=tobin@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox