From: Steve Longerbeam <slongerbeam@gmail.com>
To: linux-media@vger.kernel.org
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v5 05/12] media: imx-csi: Input connections to CSI should be optional
Date: Tue, 16 Oct 2018 17:00:20 -0700 [thread overview]
Message-ID: <20181017000027.23696-6-slongerbeam@gmail.com> (raw)
In-Reply-To: <20181017000027.23696-1-slongerbeam@gmail.com>
Some imx platforms do not have fwnode connections to all CSI input
ports, and should not be treated as an error. This includes the
imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0.
Return -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode
endpoint parsing will not treat an unconnected endpoint as an error.
Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier")
Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
---
drivers/staging/media/imx/imx-media-csi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index 176978c7dfe7..8f52428d2c75 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -1813,7 +1813,7 @@ static int imx_csi_parse_endpoint(struct device *dev,
struct v4l2_fwnode_endpoint *vep,
struct v4l2_async_subdev *asd)
{
- return fwnode_device_is_available(asd->match.fwnode) ? 0 : -EINVAL;
+ return fwnode_device_is_available(asd->match.fwnode) ? 0 : -ENOTCONN;
}
static int imx_csi_async_register(struct csi_priv *priv)
--
2.17.1
next prev parent reply other threads:[~2018-10-17 0:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181017000027.23696-1-slongerbeam@gmail.com>
2018-10-17 0:00 ` [PATCH v5 01/12] media: videodev2.h: Add more field helper macros Steve Longerbeam
2018-10-17 0:00 ` [PATCH v5 02/12] gpu: ipu-csi: Swap fields according to input/output field types Steve Longerbeam
2018-12-07 20:02 ` Steve Longerbeam
2018-12-13 12:59 ` Philipp Zabel
2018-12-14 23:40 ` Steve Longerbeam
2018-10-17 0:00 ` [PATCH v5 03/12] gpu: ipu-v3: Add planar support to interlaced scan Steve Longerbeam
2018-10-17 0:00 ` [PATCH v5 04/12] media: imx: Fix field negotiation Steve Longerbeam
2018-10-17 0:00 ` Steve Longerbeam [this message]
2018-10-17 0:00 ` [PATCH v5 06/12] media: imx-csi: Double crop height for alternate fields at sink Steve Longerbeam
2018-10-17 0:00 ` [PATCH v5 07/12] media: imx: interweave and odd-chroma-row skip are incompatible Steve Longerbeam
2018-10-17 0:00 ` [PATCH v5 08/12] media: imx-csi: Allow skipping odd chroma rows for YVU420 Steve Longerbeam
2018-10-17 0:00 ` [PATCH v5 09/12] media: imx: vdic: rely on VDIC for correct field order Steve Longerbeam
2018-10-17 0:00 ` [PATCH v5 10/12] media: imx-csi: Move crop/compose reset after filling default mbus fields Steve Longerbeam
2018-10-17 0:00 ` [PATCH v5 11/12] media: imx: Allow interweave with top/bottom lines swapped Steve Longerbeam
2018-10-17 0:00 ` [PATCH v5 12/12] media: imx.rst: Update doc to reflect fixes to interlaced capture Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017000027.23696-6-slongerbeam@gmail.com \
--to=slongerbeam@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox