From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 553B2ECDE30 for ; Wed, 17 Oct 2018 08:31:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BAF521523 for ; Wed, 17 Oct 2018 08:31:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BAF521523 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727247AbeJQQ0a (ORCPT ); Wed, 17 Oct 2018 12:26:30 -0400 Received: from mail.skyhub.de ([5.9.137.197]:40200 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726994AbeJQQ0a (ORCPT ); Wed, 17 Oct 2018 12:26:30 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Kw1q_WYL5mlW; Wed, 17 Oct 2018 10:31:35 +0200 (CEST) Received: from zn.tnic (p200300EC2BC91B00329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2bc9:1b00:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5D9261EC0319; Wed, 17 Oct 2018 10:31:35 +0200 (CEST) Date: Wed, 17 Oct 2018 10:31:26 +0200 From: Borislav Petkov To: Masahiro Yamada Cc: Leonardo =?utf-8?B?QnLDoXM=?= , lkcamp@lists.libreplanetbr.org, willy6545@gmail.com, Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , X86 ML , Michal Marek , Linux Kernel Mailing List , Linux Kbuild mailing list Subject: Re: [PATCH 1/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS Message-ID: <20181017083126.GB22535@zn.tnic> References: <20181017000809.GA21292@WindFlash> <20181017081115.GA22535@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 17, 2018 at 05:21:01PM +0900, Masahiro Yamada wrote: > scripts/Makefile.extrawarn provides options for the target compiler (CC), > whereas this patch adds -Wshadow=local for the host compiler (HOSTCC). Aha, this wants to fix shadowing for the host tools, ok. Next question: why not -Wshadow simply? Also, -Wshadow for the target compiler is an extra warning (W=2). Why is it enabled by default here? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.