public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <me@tobin.cc>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Tobin C. Harding" <tobin@kernel.org>,
	Jiri Slaby <jslaby@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] tty: Remove trailing whitespace
Date: Thu, 18 Oct 2018 16:55:38 +1100	[thread overview]
Message-ID: <20181018055538.GO9944@eros> (raw)
In-Reply-To: <20181018051933.GA26505@kroah.com>

On Thu, Oct 18, 2018 at 07:19:33AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 17, 2018 at 10:21:25AM +1100, Tobin C. Harding wrote:
> > From: "Tobin C. Harding" <me@tobin.cc>
> > 
> > Currently files under drivers/tty/ contain trailing whitespace.  This is
> > easy to fix and easy to review so lets do it now before we do other
> > kernel-docs cleanups.
> > 
> > Signed-off-by: Tobin C. Harding <tobin@kernel.org>
> 
> This patch is an example of the from and signed-off-by line not
> matching.  Seems like it happened on every-other-one.
> 
> Perhaps your git setup was wrong for when you committed the patches?

Thanks Greg, tunnel vision I only read the first 'From:' header!  I
rekon I must of done some of these patches before I setup git with the
new address.

This has the serendipitous outcome of explaining why people add that
second 'From:' in patches with a different email of their own - I've
always wondered why that was :)

Will fix and re-spin.

thanks,
Tobin.

  reply	other threads:[~2018-10-18  5:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16 23:21 [PATCH 0/7] drivers: tty: Fix kernel-docs comments Tobin C. Harding
2018-10-16 23:21 ` [PATCH 1/7] tty: Fix whitespace before tab warnings Tobin C. Harding
2018-10-16 23:21 ` [PATCH 2/7] tty: Remove trailing whitespace Tobin C. Harding
2018-10-18  5:19   ` Greg Kroah-Hartman
2018-10-18  5:55     ` Tobin C. Harding [this message]
2018-10-16 23:21 ` [PATCH 3/7] tty: Partially fix kernel-docs layout Tobin C. Harding
2018-10-16 23:21 ` [PATCH 4/7] tty: Fix kernel-doc variable typos Tobin C. Harding
2018-10-16 23:21 ` [PATCH 5/7] tty: Fix spacing between kernel-doc sections Tobin C. Harding
2018-10-16 23:21 ` [PATCH 6/7] tty: Remove newline after function kernel-doc Tobin C. Harding
2018-10-16 23:21 ` [PATCH 7/7] tty: Fix section format Tobin C. Harding
2018-10-17  7:00 ` [PATCH 0/7] drivers: tty: Fix kernel-docs comments Geert Uytterhoeven
2018-10-17  7:29   ` Tobin C. Harding
2018-10-18  0:17   ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181018055538.GO9944@eros \
    --to=me@tobin.cc \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tobin@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox