[PATCH v2] docs/uio: fix a grammar nitpick

[PATCH v2] docs/uio: fix a grammar nitpick

[Will Korteland]

This patch fixes a minor, incorrect piece of grammar in the UIO howto.

Signed-off-by: Will Korteland <will@korte.land>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
---
The sole change since v1 is that I re-did the patch against
linux-next-20181016 instead of linux. Sorry for the extra work Greg, and
thanks Randy for the acked-by.

  Documentation/driver-api/uio-howto.rst | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/driver-api/uio-howto.rst 
b/Documentation/driver-api/uio-howto.rst
index fb2eb73be4a3..25f50eace28b 100644
--- a/Documentation/driver-api/uio-howto.rst
+++ b/Documentation/driver-api/uio-howto.rst
@@ -463,8 +463,8 @@ Getting information about your UIO device

  Information about all UIO devices is available in sysfs. The first 
thing
  you should do in your driver is check ``name`` and ``version`` to make
-sure your talking to the right device and that its kernel driver has 
the
-version you expect.
+sure you're talking to the right device and that its kernel driver has
+the version you expect.

  You should also make sure that the memory mapping you need exists and
  has the size you expect.
-- 
2.19.1

Re: [PATCH v2] docs/uio: fix a grammar nitpick

[Jonathan Corbet]

On Tue, 16 Oct 2018 08:57:44 +0000 (UTC)
Will Korteland <will@korte.land> wrote:

> This patch fixes a minor, incorrect piece of grammar in the UIO howto.
> 
> Signed-off-by: Will Korteland <will@korte.land>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> The sole change since v1 is that I re-did the patch against
> linux-next-20181016 instead of linux. Sorry for the extra work Greg, and
> thanks Randy for the acked-by.

Unfortunately, this patch is badly white-space mangled.  I tried fixing
it up but eventually had to give up and move on.

Please fix up your email client so that this doesn't happen; see
Documentation/process/email-clients.rst for some helpful suggestions
to that end.  Once you can email the patch to yourself and apply the
result successfully, please resubmit it.

Thanks,

jon
> 
>   Documentation/driver-api/uio-howto.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/driver-api/uio-howto.rst 
> b/Documentation/driver-api/uio-howto.rst
> index fb2eb73be4a3..25f50eace28b 100644
> --- a/Documentation/driver-api/uio-howto.rst
> +++ b/Documentation/driver-api/uio-howto.rst
> @@ -463,8 +463,8 @@ Getting information about your UIO device
> 
>   Information about all UIO devices is available in sysfs. The first 
> thing
>   you should do in your driver is check ``name`` and ``version`` to make
> -sure your talking to the right device and that its kernel driver has 
> the
> -version you expect.
> +sure you're talking to the right device and that its kernel driver has
> +the version you expect.
> 
>   You should also make sure that the memory mapping you need exists and
>   has the size you expect.

Re: [PATCH v2] docs/uio: fix a grammar nitpick

[Will Korteland]

On 2018-10-18 18:31, Jonathan Corbet wrote:
> Unfortunately, this patch is badly white-space mangled.  I tried fixing
> it up but eventually had to give up and move on.
> 
> Please fix up your email client so that this doesn't happen; see
> Documentation/process/email-clients.rst for some helpful suggestions
> to that end.  Once you can email the patch to yourself and apply the
> result successfully, please resubmit it.

Thanks for taking the time to look at this. I might let it be, since it's
made it into linux-next-20181019 fine - I got an email from Greg KH to that
effect as well.

That said, I'll be a bit more careful next time round, just in case
someone's manually fixed up the whitespace without telling me. Thanks for
the pointer to the email docs, but unfortunately my client isn't covered
there. Still, I've used it as a guide for the kind of settings I need,
hopefully my patches won't get mangled from now on.

- Will

Re: [PATCH v2] docs/uio: fix a grammar nitpick

[Jonathan Corbet]

On Fri, 19 Oct 2018 10:55:58 +0000 (UTC)
Will Korteland <will@korte.land> wrote:

> Thanks for
> the pointer to the email docs, but unfortunately my client isn't covered
> there. Still, I've used it as a guide for the kind of settings I need,
> hopefully my patches won't get mangled from now on.

When you figure out what's needed to bring your client into line, I would
more than welcome a patch to email-clients.rst providing the necessary
information for the next person who comes along!

Thanks,

jon