RE: [PATCH V15 2/2] scsi: ufs: Add configfs support for UFS provisioning

Avri Altman
2018-10-16T09:43:28Z

Hi,

> +++ b/drivers/scsi/ufs/Makefile
> @@ -4,6 +4,8 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PCI) += tc-dwc-g210-
> pci.o ufshcd-dwc.o tc-dwc-g210.
> obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) += tc-dwc-g210-pltfrm.o
> ufshcd-dwc.o tc-dwc-g210.o
> obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
> obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
> -ufshcd-core-objs := ufshcd.o ufs-sysfs.o
> +ufshcd-core-objs-y := ufshcd.o ufs-sysfs.o
> +ufshcd-core-objs-$(CONFIG_SCSI_UFS_PROVISION) += ufs-configfs.o
> +ufshcd-core-objs := $(ufshcd-core-objs-y)
This will work, but I think it should be:
ufshcd-core-y += ufshcd.o ufs-sysfs.o
ufshcd-core-$( CONFIG_SCSI_UFS_PROVISION) += ufs-configfs.o

Also, you may want to rebase your patches with Martin's 4.20/scsi-queue

Thanks,
Avri