[PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq

[PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq

[Yangtao Li]

---
 kernel/softirq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index 6f584861d329..6193e1d1b30d 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
 	int softirq_bit;
 
 	/*
-	 * Mask out PF_MEMALLOC s current task context is borrowed for the
+	 * Mask out PF_MEMALLOC as current task context is borrowed for the
 	 * softirq. A softirq handled such as network RX might set PF_MEMALLOC
 	 * again if the socket is related to swap
 	 */
-- 
2.17.0

Re: [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq

[Steven Rostedt]

I don't know if the trivial tree is dead or not, but this would be a
prime candidate.

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve


On Thu, 18 Oct 2018 10:21:33 -0400
Yangtao Li <tiny.windzz@gmail.com> wrote:

> ---
>  kernel/softirq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index 6f584861d329..6193e1d1b30d 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
>  	int softirq_bit;
>  
>  	/*
> -	 * Mask out PF_MEMALLOC s current task context is borrowed for the
> +	 * Mask out PF_MEMALLOC as current task context is borrowed for the
>  	 * softirq. A softirq handled such as network RX might set PF_MEMALLOC
>  	 * again if the socket is related to swap
>  	 */

Re: [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq

[Frank Lee]

This place looks like a small mistake. :-)

-- Yangtao Li

>On Thu, 18 Oct 2018
>Steven Rostedt (VMware) <rostedt@goodmis.org> wrote:
>I don't know if the trivial tree is dead or not, but this would be a
>prime candidate.
>
>Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
>-- Steve
>
>
>On Thu, 18 Oct 2018 10:21:33 -0400
>Yangtao Li <tiny.windzz@gmail.com> wrote:
>
>> ---
>>  kernel/softirq.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/softirq.c b/kernel/softirq.c
>> index 6f584861d329..6193e1d1b30d 100644
>> --- a/kernel/softirq.c
>> +++ b/kernel/softirq.c
>> @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
>>   int softirq_bit;
>>
>>   /*
>> - * Mask out PF_MEMALLOC s current task context is borrowed for the
>> + * Mask out PF_MEMALLOC as current task context is borrowed for the
>>   * softirq. A softirq handled such as network RX might set PF_MEMALLOC
>>   * again if the socket is related to swap
>>   */

On Thu, Oct 18, 2018 at 10:21 PM Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> ---
>  kernel/softirq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index 6f584861d329..6193e1d1b30d 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
>         int softirq_bit;
>
>         /*
> -        * Mask out PF_MEMALLOC s current task context is borrowed for the
> +        * Mask out PF_MEMALLOC as current task context is borrowed for the
>          * softirq. A softirq handled such as network RX might set PF_MEMALLOC
>          * again if the socket is related to swap
>          */
> --
> 2.17.0
>

Re: [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq

[Ingo Molnar]

* Yangtao Li <tiny.windzz@gmail.com> wrote:

> ---
>  kernel/softirq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index 6f584861d329..6193e1d1b30d 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
>  	int softirq_bit;
>  
>  	/*
> -	 * Mask out PF_MEMALLOC s current task context is borrowed for the
> +	 * Mask out PF_MEMALLOC as current task context is borrowed for the
>  	 * softirq. A softirq handled such as network RX might set PF_MEMALLOC
>  	 * again if the socket is related to swap
>  	 */

Can I add your Signed-off-by?

Thanks,

	Ingo

[tip:irq/core] softirq: Fix typo in __do_softirq() comments

[tip-bot for Yangtao Li]

Commit-ID:  e45506ac0af9b56b221863e9649fe122d8bb42ff
Gitweb:     https://git.kernel.org/tip/e45506ac0af9b56b221863e9649fe122d8bb42ff
Author:     Yangtao Li <tiny.windzz@gmail.com>
AuthorDate: Thu, 18 Oct 2018 10:21:33 -0400
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 18 Oct 2018 18:10:23 +0200

softirq: Fix typo in __do_softirq() comments

s/s/as

[ mingo: Also add a missing 'the', add proper punctuation and clarify what 'swap' means here. ]

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: alexander.levin@verizon.com
Cc: frederic@kernel.org
Cc: joel@joelfernandes.org
Cc: paulmck@linux.vnet.ibm.com
Cc: rostedt@goodmis.org
Link: http://lkml.kernel.org/r/20181018142133.12341-1-tiny.windzz@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/softirq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index 6f584861d329..9526895fe4ac 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -257,9 +257,9 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
 	int softirq_bit;
 
 	/*
-	 * Mask out PF_MEMALLOC s current task context is borrowed for the
-	 * softirq. A softirq handled such as network RX might set PF_MEMALLOC
-	 * again if the socket is related to swap
+	 * Mask out PF_MEMALLOC as the current task context is borrowed for the
+	 * softirq. A softirq handled, such as network RX, might set PF_MEMALLOC
+	 * again if the socket is related to swapping.
 	 */
 	current->flags &= ~PF_MEMALLOC;
 

Re: [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq

[Frank Lee]

>On Thu, 18 Oct 2018
>Ingo Molnar <mingo@kernel.org> wrote:
>* Yangtao Li <tiny.windzz@gmail.com> wrote:
>
>> ---
>>  kernel/softirq.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/softirq.c b/kernel/softirq.c
>> index 6f584861d329..6193e1d1b30d 100644
>> --- a/kernel/softirq.c
>> +++ b/kernel/softirq.c
>> @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
>>   int softirq_bit;
>>
>>   /*
>> - * Mask out PF_MEMALLOC s current task context is borrowed for the
>> + * Mask out PF_MEMALLOC as current task context is borrowed for the
>>   * softirq. A softirq handled such as network RX might set PF_MEMALLOC
>>   * again if the socket is related to swap
>>   */
>
>Can I add your Signed-off-by?
>
>Thanks,
>
> Ingo

yeah，Thanks

-- Yangtao Li

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
On Fri, Oct 19, 2018 at 12:10 AM Ingo Molnar <mingo@kernel.org> wrote:
>
>
> * Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> > ---
> >  kernel/softirq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/softirq.c b/kernel/softirq.c
> > index 6f584861d329..6193e1d1b30d 100644
> > --- a/kernel/softirq.c
> > +++ b/kernel/softirq.c
> > @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
> >       int softirq_bit;
> >
> >       /*
> > -      * Mask out PF_MEMALLOC s current task context is borrowed for the
> > +      * Mask out PF_MEMALLOC as current task context is borrowed for the
> >        * softirq. A softirq handled such as network RX might set PF_MEMALLOC
> >        * again if the socket is related to swap
> >        */
>
> Can I add your Signed-off-by?
>
> Thanks,
>
>         Ingo