Re: [PATCH] net: ethernet: fec: Add missing SPEED_

Andrew Lunn
2018-10-20T16:05:20Z

> >> I have patched by adding:
> >> phy_remove_link_mode(phy_dev, ETHTOOL_LINK_MODE_Asym_Pause_BIT);
>
> Instead of programmatically removing the feature bit it should be
> possible to do this in the PHY driver configuration. See also
> this part of phy_probe().
>
> if (phydrv->features & (SUPPORTED_Pause | SUPPORTED_Asym_Pause)) {
> phydev->supported &= ~(SUPPORTED_Pause | SUPPORTED_Asym_Pause);
> phydev->supported |= phydrv->features &
> (SUPPORTED_Pause | SUPPORTED_Asym_Pause);
> } else {
> phydev->supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;
> }

Sorry for the late reply. Been on vacation.

I need to check the datasheet, but it seems like the KSZ9021 does not
support asym pause. Using the above code is the correct way to solve
this problem. Look at the bcm63xx.c:bcm63xx_config_init() which does
this.

I will cook up a patch.

Andrew