public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
	"Joel Fernandes (Google)" <joel@joelfernandes.org>,
	Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH pstore-next v2 0/4] Refactor compression initialization
Date: Thu, 18 Oct 2018 15:01:24 -0700	[thread overview]
Message-ID: <20181018220124.GA14768@roeck-us.net> (raw)
In-Reply-To: <20181018185616.14768-1-keescook@chromium.org>

On Thu, Oct 18, 2018 at 11:56:12AM -0700, Kees Cook wrote:
> Sai noticed pstore wasn't catching early crashes, so Joel fixed it
> by moving init earlier again (with compression init done later). I
> refactored things a bit to avoid modular build problems noticed by
> Guenter. And while doing this work, I also improved /proc/iomem labels
> after Dan helped me get NVDIMM working so I could meaningfully test the
> very early crash handling.
> 
> Thanks everyone!
> 

This version fixes the compile failure. pstore also still works with the
series applied on top of v4.19-rc8; tested on a Chromebook.

Tested-by: Guenter Roeck <groeck@chromium.org>

Guenter

> -Kees
> 
> v2:
> - add init refactoring to avoid modular build failures.
> 
> 
> Joel Fernandes (Google) (1):
>   pstore: Allocate compression during late_initcall()
> 
> Kees Cook (3):
>   pstore: Centralize init/exit routines
>   pstore: Refactor compression initialization
>   pstore/ram: Clarify resource reservation labels
> 
>  fs/pstore/inode.c          | 11 +-----
>  fs/pstore/internal.h       |  5 ++-
>  fs/pstore/platform.c       | 75 +++++++++++++++++++++++++++++++-------
>  fs/pstore/ram.c            | 18 +++++++--
>  fs/pstore/ram_core.c       | 11 ++++--
>  include/linux/pstore_ram.h |  3 +-
>  6 files changed, 90 insertions(+), 33 deletions(-)
> 
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2018-10-18 22:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 18:56 [PATCH pstore-next v2 0/4] Refactor compression initialization Kees Cook
2018-10-18 18:56 ` [PATCH pstore-next v2 1/4] pstore: Centralize init/exit routines Kees Cook
2018-10-18 18:56 ` [PATCH pstore-next v2 2/4] pstore: Allocate compression during late_initcall() Kees Cook
2019-05-03 18:37   ` Douglas Anderson
2019-05-05 13:16     ` Greg KH
2019-05-06 15:16       ` Doug Anderson
2019-05-06 15:38         ` Kees Cook
2019-05-06 16:05           ` Kees Cook
2019-05-20 11:07             ` Greg KH
2018-10-18 18:56 ` [PATCH pstore-next v2 3/4] pstore: Refactor compression initialization Kees Cook
2018-10-18 18:56 ` [PATCH pstore-next v2 4/4] pstore/ram: Clarify resource reservation labels Kees Cook
2018-10-18 22:01 ` Guenter Roeck [this message]
2018-10-18 22:12   ` [PATCH pstore-next v2 0/4] Refactor compression initialization Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181018220124.GA14768@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=anton@enomsg.org \
    --cc=ccross@android.com \
    --cc=dan.j.williams@intel.com \
    --cc=joel@joelfernandes.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox