Re: [PATCH 01/10] swiotlb: remove a pointless comment

Konrad Rzeszutek Wilk
2018-10-19T00:10:04Z

On Mon, Oct 08, 2018 at 10:02:37AM +0200, Christoph Hellwig wrote:
> This comments describes an aspect of the map_sg interface that isn't
> even exploited by swiotlb.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thank you!
> ---
> kernel/dma/swiotlb.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 4f8a6dbf0b60..9062b14bc7f4 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -925,12 +925,6 @@ swiotlb_sync_single_for_device(struct device *hwdev, dma_addr_t dev_addr,
> * appropriate dma address and length. They are obtained via
> * sg_dma_{address,length}(SG).
> *
> - * NOTE: An implementation may be able to use a smaller number of
> - * DMA address/length pairs than there are SG table elements.
> - * (for example via virtual mapping capabilities)
> - * The routine returns the number of addr/length pairs actually
> - * used, at most nents.
> - *
> * Device ownership issues as mentioned above for swiotlb_map_page are the
> * same here.
> */
> --
> 2.19.0
>