From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lee.jones@linaro.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <linus.walleij@linaro.org>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>,
<linux-clk@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] regulator: lochnagar: Add support for the Cirrus Logic Lochnagar
Date: Fri, 19 Oct 2018 13:19:20 +0100 [thread overview]
Message-ID: <20181019121920.GL1653@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20181019112622.GB5895@sirena.org.uk>
On Fri, Oct 19, 2018 at 12:26:22PM +0100, Mark Brown wrote:
> On Fri, Oct 19, 2018 at 10:50:02AM +0100, Charles Keepax wrote:
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code. Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.
>
I don't think any of this has been applied anywhere yet.
> > +++ b/drivers/regulator/lochnagar-regulator.c
> > @@ -0,0 +1,255 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Lochnagar regulator driver
>
> Please don't mix C and C++ comments like this in the same block, just
> have it be a C++ block so it looks consistent.
Can do.
Thanks,
Charles
next prev parent reply other threads:[~2018-10-19 12:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 9:49 [PATCH v3 1/5] mfd: lochnagar: Add initial binding documentation Charles Keepax
2018-10-19 9:50 ` [PATCH v3 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar Charles Keepax
2018-10-19 9:50 ` [PATCH v3 3/5] clk: " Charles Keepax
2018-10-19 9:50 ` [PATCH v3 4/5] regulator: " Charles Keepax
2018-10-19 11:26 ` Mark Brown
2018-10-19 12:02 ` Richard Fitzgerald
2018-10-19 12:06 ` Mark Brown
2018-10-19 12:19 ` Charles Keepax [this message]
2018-10-19 12:21 ` Mark Brown
2018-10-19 12:34 ` Charles Keepax
2018-10-19 12:38 ` Mark Brown
2018-10-19 9:50 ` [PATCH v3 5/5] pinctrl: " Charles Keepax
2018-10-30 13:04 ` Linus Walleij
2018-10-30 13:59 ` Charles Keepax
2018-10-19 18:08 ` [PATCH v3 1/5] mfd: lochnagar: Add initial binding documentation Stephen Boyd
2018-10-30 13:10 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019121920.GL1653@imbe.wolfsonmicro.main \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox