From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2351C67863 for ; Sat, 20 Oct 2018 18:59:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43A2F2157C for ; Sat, 20 Oct 2018 18:59:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="4b3uWapK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43A2F2157C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727682AbeJUDLQ (ORCPT ); Sat, 20 Oct 2018 23:11:16 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:39025 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727413AbeJUDLQ (ORCPT ); Sat, 20 Oct 2018 23:11:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=8kmkDCoZmqYKf4VyVB0zMdxW6hEP3IDpzvcuJ/13TBY=; b=4b3uWapKh+0J4NhEPRkxIfNZCJ2j0HVfp3Lf0gTXZv4Pwhh28q1ODAMKedsGSbYoExpeEzSDyF/Gmaq7G5VQ5Yx8dMm8ZXOdnPAzClfdJStLk7m3o2y5SM6+V2EcfrrGu6nppiRhaNGRdxHrZ8T3JAX7Wrlkclxm+hHrBc5118Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1gDwTT-0003LH-A2; Sat, 20 Oct 2018 20:59:47 +0200 Date: Sat, 20 Oct 2018 20:59:47 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , LABBE Corentin , davem@davemloft.net, fugang.duan@nxp.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: ethernet: fec: Add missing SPEED_ Message-ID: <20181020185947.GA6615@lunn.ch> References: <2621cbc9-47ed-ce2a-b7ee-262f17dc138f@gmail.com> <20181018184715.GA31736@Red> <20181018191612.GB31736@Red> <5cb0731b-83c5-5ed5-d022-98f8627d1737@gmail.com> <20181018195909.GA11317@Red> <1b784f69-3ec2-feb2-81e1-9a335cf477c3@gmail.com> <20181020153922.GC1596@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I dare to dispute here ;) Above code snippet from phy_probe() will > (try to) set also SUPPORTED_Asym_Pause, because phydrv->features > doesn't include any of the two pause flags. > The statement in bcm63xx_config_init you refer to seems to be a > no-op to me therefore. > > I'd say the correct way is to change the PHY config like this: > .features = PHY_BASIC_FEATURES | SUPPORTED_Pause; > It's exactly the use case the code snippet above covers. Yes, you are correct. But it is no longer possible to just do PHY_BASIC_FEATURES | SUPPORTED_Pause because .features is no loner a u32 but a linux bitmap. We need to keep the same idea, allow the PHY driver to indicate it supports a subset of Pause, and if not, enable pause by default. Maybe the easiest way is to move this chunk of code to after the probe function is called. Andrew