From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
LABBE Corentin <clabbe@baylibre.com>,
davem@davemloft.net, fugang.duan@nxp.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: fec: Add missing SPEED_
Date: Sat, 20 Oct 2018 22:12:17 +0200 [thread overview]
Message-ID: <20181020201217.GB6615@lunn.ch> (raw)
In-Reply-To: <1153d0a5-1c23-1e14-7ebd-459886af957a@gmail.com>
> > Yes, you are correct.
> >
> > But it is no longer possible to just do PHY_BASIC_FEATURES |
> > SUPPORTED_Pause because .features is no loner a u32 but a linux
> > bitmap.
> >
> Ahh, missed that.
Yes, easy to miss, since it is still work in progress. The next
patchset completes the migration, making phydev->advertise and
phydev->supported bitmaps.
> > We need to keep the same idea, allow the PHY driver to indicate it
> > supports a subset of Pause, and if not, enable pause by default.
> >
> Could the PHY driver define its own bitmap instead of pointing to
> one of the predefined ones?
I'm actually just adding a few more pre-defined ones. I suspect they
will get used by more than one driver. These changed have uncovered a
few bugs with pause, and i would not be surprised to find there are
more still to be found.
Andrew
next prev parent reply other threads:[~2018-10-20 20:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 15:05 [PATCH] net: ethernet: fec: Add missing SPEED_ Corentin Labbe
2018-10-18 18:39 ` Florian Fainelli
2018-10-18 18:47 ` LABBE Corentin
2018-10-18 18:55 ` Florian Fainelli
2018-10-18 19:16 ` LABBE Corentin
2018-10-18 19:38 ` Florian Fainelli
2018-10-18 19:59 ` LABBE Corentin
2018-10-18 20:10 ` Florian Fainelli
2018-10-18 20:41 ` Heiner Kallweit
2018-10-19 7:07 ` Andy Duan
2018-10-20 15:39 ` Andrew Lunn
2018-10-20 15:51 ` Heiner Kallweit
2018-10-20 18:59 ` Andrew Lunn
2018-10-20 19:26 ` Heiner Kallweit
2018-10-20 20:12 ` Andrew Lunn [this message]
2018-10-20 20:32 ` Andrew Lunn
2018-10-19 14:42 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181020201217.GB6615@lunn.ch \
--to=andrew@lunn.ch \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox