From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F131FC67863 for ; Mon, 22 Oct 2018 08:02:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C190320658 for ; Mon, 22 Oct 2018 08:02:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C190320658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727744AbeJVQTa (ORCPT ); Mon, 22 Oct 2018 12:19:30 -0400 Received: from mail.bootlin.com ([62.4.15.54]:42739 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727523AbeJVQTa (ORCPT ); Mon, 22 Oct 2018 12:19:30 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 97C16207A3; Mon, 22 Oct 2018 10:02:02 +0200 (CEST) Received: from bbrezillon (aaubervilliers-681-1-25-52.w90-88.abo.wanadoo.fr [90.88.145.52]) by mail.bootlin.com (Postfix) with ESMTPSA id 37AB220711; Mon, 22 Oct 2018 10:01:52 +0200 (CEST) Date: Mon, 22 Oct 2018 10:01:52 +0200 From: Boris Brezillon To: Yogesh Narayan Gaur Cc: Cyrille Pitchen , Tudor Ambarus , "marek.vasut@gmail.com" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "richard@nod.at" , "linux-kernel@vger.kernel.org" , "nicolas.ferre@microchip.com" , "cyrille.pitchen@microchip.com" , "linux-mtd@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "Cristian.Birsan@microchip.com" , Mark Brown Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories Message-ID: <20181022100152.05da1b6c@bbrezillon> In-Reply-To: References: <20180911154007.17195-1-tudor.ambarus@microchip.com> <20180911154007.17195-2-tudor.ambarus@microchip.com> <31a8f6a9-1459-443a-6ef8-2b2c17769ae4@microchip.com> <20181017090724.12f2cd79@bbrezillon> <20181017091045.124e0266@bbrezillon> <20181017092941.3658bd9a@bbrezillon> <20181017115237.07310b74@bbrezillon> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Oct 2018 06:04:13 +0000 Yogesh Narayan Gaur wrote: > -static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32 *smpt) > +static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32 *smpt, u32 smpt_len) > { > const u32 *ret = NULL; > - u32 i, addr; > + u32 i, addr, nmaps; > int err; > u8 addr_width, read_opcode, read_dummy; > u8 read_data_mask, data_byte, map_id; > + bool map_id_is_valid = false; > > addr_width = nor->addr_width; > read_dummy = nor->read_dummy; > read_opcode = nor->read_opcode; > > + for (i = 0; i + pr_info("%s:%i smpt[%d]=%08x\n", __func__, __LINE__, i, smpt[i]); > + > map_id = 0; > - i = 0; > /* Determine if there are any optional Detection Command Descriptors */ > - while (!(smpt[i] & SMPT_DESC_TYPE_MAP)) { > + for (i = 0; i< smpt_len; i++) { > + if (!(smpt[i] & SMPT_DESC_TYPE_MAP)) > + break; > + > read_data_mask = SMPT_CMD_READ_DATA(smpt[i]); > nor->addr_width = spi_nor_smpt_addr_width(nor, smpt[i]); > nor->read_dummy = spi_nor_smpt_read_dummy(nor, smpt[i]); Could you also print the ->addr_width, ->read_dummy and ->read_opcode here? > @@ -2894,18 +2900,35 @@ static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32 *smpt) > * Configuration that is currently in use. > */ > map_id = map_id << 1 | !!(data_byte & read_data_mask); > + map_id_is_valid = true; > i = i + 2; > }