From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC8FC004D3 for ; Mon, 22 Oct 2018 10:25:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FC9420652 for ; Mon, 22 Oct 2018 10:25:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FC9420652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728874AbeJVSnZ (ORCPT ); Mon, 22 Oct 2018 14:43:25 -0400 Received: from mail.bootlin.com ([62.4.15.54]:46226 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728604AbeJVSnY (ORCPT ); Mon, 22 Oct 2018 14:43:24 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id B440020DB5; Mon, 22 Oct 2018 12:25:26 +0200 (CEST) Received: from bbrezillon (aaubervilliers-681-1-25-52.w90-88.abo.wanadoo.fr [90.88.145.52]) by mail.bootlin.com (Postfix) with ESMTPSA id 52AFA207A3; Mon, 22 Oct 2018 12:25:16 +0200 (CEST) Date: Mon, 22 Oct 2018 12:25:16 +0200 From: Boris Brezillon To: Yogesh Narayan Gaur Cc: Tudor Ambarus , "richard@nod.at" , Mark Brown , "linux-kernel@vger.kernel.org" , "nicolas.ferre@microchip.com" , "marek.vasut@gmail.com" , "cyrille.pitchen@microchip.com" , "linux-mtd@lists.infradead.org" , "Cristian.Birsan@microchip.com" , Cyrille Pitchen , "computersforpeace@gmail.com" , "dwmw2@infradead.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories Message-ID: <20181022122516.24ff2dae@bbrezillon> In-Reply-To: References: <20180911154007.17195-1-tudor.ambarus@microchip.com> <20180911154007.17195-2-tudor.ambarus@microchip.com> <31a8f6a9-1459-443a-6ef8-2b2c17769ae4@microchip.com> <20181017090724.12f2cd79@bbrezillon> <20181017091045.124e0266@bbrezillon> <20181017092941.3658bd9a@bbrezillon> <20181017115237.07310b74@bbrezillon> <20181022111543.2a607efc@bbrezillon> <20181022121044.24039f40@bbrezillon> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Oct 2018 10:17:58 +0000 Yogesh Narayan Gaur wrote: > It works, Not really. > [ 1.628162] m25p80 spi0.0: found s25fl512s, expected m25p80 > [ 1.633854] Start [addr_width:00000000, read_dumy:08, read_opcode:00000000] > [ 1.640811] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc > [ 1.646117] spi_nor_get_map_in_use:2882 smpt[1]=00000004 > [ 1.651421] spi_nor_get_map_in_use:2882 smpt[2]=04ff65fc > [ 1.656724] spi_nor_get_map_in_use:2882 smpt[3]=00000002 > [ 1.662028] spi_nor_get_map_in_use:2882 smpt[4]=02ff65fd > [ 1.667331] spi_nor_get_map_in_use:2882 smpt[5]=00000004 > [ 1.672635] spi_nor_get_map_in_use:2882 smpt[6]=ff0201fe > [ 1.677937] spi_nor_get_map_in_use:2882 smpt[7]=00007ff1 > [ 1.683240] spi_nor_get_map_in_use:2882 smpt[8]=00037ff4 > [ 1.688542] spi_nor_get_map_in_use:2882 smpt[9]=03fbfff4 > [ 1.693845] spi_nor_get_map_in_use:2882 smpt[10]=ff0203fe > [ 1.699234] spi_nor_get_map_in_use:2882 smpt[11]=03fbfff4 > [ 1.704625] spi_nor_get_map_in_use:2882 smpt[12]=00037ff4 > [ 1.710014] spi_nor_get_map_in_use:2882 smpt[13]=00007ff1 > [ 1.715403] spi_nor_get_map_in_use:2882 smpt[14]=ff0005ff > [ 1.720791] spi_nor_get_map_in_use:2882 smpt[15]=03fffff4 > [ 1.726180] smpt[0]=[addr_width:00000000, read_dumy:08, read_opcode:00000065] There's still a problem here: you should see this trace 3 times since we have 3 command descriptors. And of course, the addr_width and read_dummy are wrong. > [ 1.733320] spi_nor_get_map_in_use:2912 map_id=0 smpt_len:16 i=:3 > [ 1.739406] End [addr_width:00000000, read_dumy:08, read_opcode:00000065] > [ 1.746204] m25p80 spi0.0: s25fl512s (65536 Kbytes)