From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98ED2C004D3 for ; Mon, 22 Oct 2018 10:53:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 482C920658 for ; Mon, 22 Oct 2018 10:53:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 482C920658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728706AbeJVTLP (ORCPT ); Mon, 22 Oct 2018 15:11:15 -0400 Received: from mail.bootlin.com ([62.4.15.54]:47313 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728101AbeJVTLO (ORCPT ); Mon, 22 Oct 2018 15:11:14 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id E694D20890; Mon, 22 Oct 2018 12:53:09 +0200 (CEST) Received: from bbrezillon (aaubervilliers-681-1-25-52.w90-88.abo.wanadoo.fr [90.88.145.52]) by mail.bootlin.com (Postfix) with ESMTPSA id 898552072D; Mon, 22 Oct 2018 12:52:59 +0200 (CEST) Date: Mon, 22 Oct 2018 12:52:59 +0200 From: Boris Brezillon To: Yogesh Narayan Gaur , "Cristian.Birsan@microchip.com" Cc: Tudor Ambarus , "richard@nod.at" , Mark Brown , "linux-kernel@vger.kernel.org" , "nicolas.ferre@microchip.com" , "marek.vasut@gmail.com" , "cyrille.pitchen@microchip.com" , "linux-mtd@lists.infradead.org" , Cyrille Pitchen , "computersforpeace@gmail.com" , "dwmw2@infradead.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories Message-ID: <20181022125259.42df83ea@bbrezillon> In-Reply-To: <20181022124627.2c6c3b93@bbrezillon> References: <20180911154007.17195-1-tudor.ambarus@microchip.com> <20180911154007.17195-2-tudor.ambarus@microchip.com> <31a8f6a9-1459-443a-6ef8-2b2c17769ae4@microchip.com> <20181017090724.12f2cd79@bbrezillon> <20181017091045.124e0266@bbrezillon> <20181017092941.3658bd9a@bbrezillon> <20181017115237.07310b74@bbrezillon> <20181022111543.2a607efc@bbrezillon> <20181022122659.0675942e@bbrezillon> <20181022124627.2c6c3b93@bbrezillon> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Oct 2018 12:46:27 +0200 Boris Brezillon wrote: > On Mon, 22 Oct 2018 10:39:48 +0000 > Yogesh Narayan Gaur wrote: > > > > > [ 1.632190] Start [addr_width:00000000, read_dumy:08, read_opcode:00000000] > > [ 1.639148] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc > > [ 1.644451] spi_nor_get_map_in_use:2882 smpt[1]=00000004 > > [ 1.649755] spi_nor_get_map_in_use:2882 smpt[2]=04ff65fc > > [ 1.655057] spi_nor_get_map_in_use:2882 smpt[3]=00000002 > > [ 1.660360] spi_nor_get_map_in_use:2882 smpt[4]=02ff65fd > > [ 1.665662] spi_nor_get_map_in_use:2882 smpt[5]=00000004 > > [ 1.670965] spi_nor_get_map_in_use:2882 smpt[6]=ff0201fe > > [ 1.676267] spi_nor_get_map_in_use:2882 smpt[7]=00007ff1 > > [ 1.681571] spi_nor_get_map_in_use:2882 smpt[8]=00037ff4 > > [ 1.686874] spi_nor_get_map_in_use:2882 smpt[9]=03fbfff4 > > [ 1.692176] spi_nor_get_map_in_use:2882 smpt[10]=ff0203fe > > [ 1.697566] spi_nor_get_map_in_use:2882 smpt[11]=03fbfff4 > > [ 1.702954] spi_nor_get_map_in_use:2882 smpt[12]=00037ff4 > > [ 1.708343] spi_nor_get_map_in_use:2882 smpt[13]=00007ff1 > > [ 1.713732] spi_nor_get_map_in_use:2882 smpt[14]=ff0005ff > > [ 1.719120] spi_nor_get_map_in_use:2882 smpt[15]=03fffff4 > > [ 1.724509] smpt[0]=[addr_width:00000000, read_dumy:08, read_opcode:00000065] > > [ 1.731650] smpt[1]=[addr_width:00000000, read_dumy:08, read_opcode:00000000] > > [ 1.738791] smpt[2]=[addr_width:00000000, read_dumy:08, read_opcode:00000065] > > You still don't print read_dummy correctly: %0x8 -> %08x. > > Can you add > > if (!nor->addr_width) > nor->addr_width = 3; > > After the > > nor->addr_width = spi_nor_smpt_addr_width(nor, smpt[i]); > > line. And you should also try to force ->read_dummy to 8, because according to the spec, the default read_latency is 8 for this chip. With that in place, you should get an map_id of 1, 3 or 5. > > > [ 1.745932] spi_nor_get_map_in_use:2911 map_id=0 smpt_len:16 i=:3 > > [ 1.752018] End [addr_width:00000000, read_dumy:08, read_opcode:00000065] > > > > Also, one more thing when we are returning from the function, we are over-writing the values of addr_widthm read_dummy and read_opcode. > > Is this correct? > > Yes, that's correct. > > > > > out: > > nor->addr_width = addr_width; > > nor->read_dummy = read_dummy; > > nor->read_opcode = read_opcode; > > return ret; > > } > > > >