From: Rob Herring <robh@kernel.org>
To: Evan Green <evgreen@chromium.org>
Cc: Andy Gross <andy.gross@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Douglas Anderson <dianders@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
devicetree@vger.kernel.org, Can Guo <cang@codeaurora.org>,
linux-kernel@vger.kernel.org,
Manu Gautam <mgautam@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v3 1/5] dt-bindings: phy-qcom-qmp: Fix register underspecification
Date: Tue, 23 Oct 2018 10:35:17 -0500 [thread overview]
Message-ID: <20181023153517.GA24710@bogus> (raw)
In-Reply-To: <20181022205102.74825-2-evgreen@chromium.org>
On Mon, Oct 22, 2018 at 01:50:58PM -0700, Evan Green wrote:
> Add register regions for the second lane of dual-lane nodes.
> This additional specification is needed so that the driver can stop
> reaching beyond the tx and rx register allocations to get at the
> second lane registers in a dual-lane PHY.
>
> While in there, document #clock-cells as optional for PHYs that don't
> provide a pipe clock. Also, document the pcs_misc register region, which
> was being quietly supplied and used.
>
> Signed-off-by: Evan Green <evgreen@chromium.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Added dt bindings change, corresponding driver fixup, and USB PHY fixup
Please see my reply on v2.
>
> .../devicetree/bindings/phy/qcom-qmp-phy.txt | 73 +++++++++++++++++++---
> 1 file changed, 65 insertions(+), 8 deletions(-)
next prev parent reply other threads:[~2018-10-23 15:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 20:50 [PATCH v3 0/5] arm64: dts: qcom: sdm845: Add UFS DT nodes Evan Green
2018-10-22 20:50 ` [PATCH v3 1/5] dt-bindings: phy-qcom-qmp: Fix register underspecification Evan Green
2018-10-23 15:35 ` Rob Herring [this message]
2018-10-22 20:50 ` [PATCH v3 2/5] phy: qcom-qmp: Utilize fully-specified DT registers Evan Green
2018-10-22 20:51 ` [PATCH v3 3/5] arm64: dts: qcom: sdm845: add UFS controller Evan Green
2018-10-22 20:51 ` [PATCH v3 4/5] arm64: dts: qcom: sdm845: Add UFS nodes for sdm845-mtp Evan Green
2018-10-22 20:51 ` [PATCH v3 5/5] arm64: dts: qcom: sdm845: Add USB PHY lane two Evan Green
2018-10-22 22:09 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023153517.GA24710@bogus \
--to=robh@kernel.org \
--cc=andy.gross@linaro.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox