Re: [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver

Luis de Oliveira
2019-01-10T17:00:19Z

Hi Laurent,

Sorry for taking so long to answer. I was stuck in other projects and lost track
of this.

My answers inline,

On 14-Nov-18 20:22, Laurent Pinchart wrote:
> Hi Luis,
>
> Thank you for the patch.
>
> On Friday, 19 October 2018 15:52:26 EET Luis Oliveira wrote:
>> Add the Synopsys MIPI CSI-2 controller driver. This
>> controller driver is divided in platform dependent functions
>> and core functions. It also includes a platform for future
>> DesignWare drivers.
>>
>> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
>> ---
>> Changelog
>> v2-V3
>> - exposed IPI settings to userspace
>
> Could you please explain why you need this and can't use standard APIs ?
> Custom sysfs attributes are needed, they need to be documented in
> Documentation/ABI/.
>

IPI - Image Pixel Interface enables to access direct video stream in our CSI-2
Host IP and needs to be configured to match the video source. I can't hard code
it. But maybe I can think of a way to configure it using the video configuration.
I will try do that in the next patchset.

>> - fixed headers
>>
>> MAINTAINERS | 11 +
>> drivers/media/platform/dwc/Kconfig | 30 +-
>> drivers/media/platform/dwc/Makefile | 2 +
>> drivers/media/platform/dwc/dw-csi-plat.c | 699 ++++++++++++++++++++++++++++
>> drivers/media/platform/dwc/dw-csi-plat.h | 77 ++++
>> drivers/media/platform/dwc/dw-mipi-csi.c | 494 ++++++++++++++++++++++
>> drivers/media/platform/dwc/dw-mipi-csi.h | 202 +++++++++
>> include/media/dwc/dw-mipi-csi-pltfrm.h | 102 +++++
>> 8 files changed, 1616 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/media/platform/dwc/dw-csi-plat.c
>> create mode 100644 drivers/media/platform/dwc/dw-csi-plat.h
>> create mode 100644 drivers/media/platform/dwc/dw-mipi-csi.c
>> create mode 100644 drivers/media/platform/dwc/dw-mipi-csi.h
>> create mode 100644 include/media/dwc/dw-mipi-csi-pltfrm.h
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index da2e509..fd5f1fc 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -14032,6 +14032,16 @@ S: Maintained
>> F: drivers/dma/dwi-axi-dmac/
>> F: Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt
>>
>> +SYNOPSYS DESIGNWARE MIPI CSI-2 HOST VIDEO PLATFORM
>> +M: Luis Oliveira <luis.oliveira@synopsys.com>
>> +L: linux-media@vger.kernel.org
>> +T: git git://linuxtv.org/media_tree.git
>> +S: Maintained
>> +F: drivers/media/platform/dwc
>> +F: include/media/dwc/dw-mipi-csi-pltfrm.h
>> +F: Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt
>> +F: Documentation/devicetree/bindings/phy/snps,dphy-rx.txt
>
> These two lines belong to patches 1/4 and 3/4. Doesn't checkpatch.pl warn
> about this ? Now that I mentioned checkpatch.pl, I tried running it on this
> series, and it generates a fair number of warnings and errors. Could you
> please fix them ?
>

I did, but maybe - or probably - i did not fix them all. Sorry.
I am preparing a new patchset and I will make sure everything goes right this time.

>> +
>> SYNOPSYS DESIGNWARE DMAC DRIVER
>> M: Viresh Kumar <vireshk@kernel.org>
>> R: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> @@ -16217,3 +16227,4 @@ T: git
>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git S: Buried
>> alive in reporters
>> F: *
>> F: */
>> +
>
> Stray new line.
>
Noted.

> [snip]
>
Thank you,
Luis