From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07DD3C46475 for ; Thu, 25 Oct 2018 08:43:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B48BD2085B for ; Thu, 25 Oct 2018 08:43:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B48BD2085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727129AbeJYRPR (ORCPT ); Thu, 25 Oct 2018 13:15:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:40572 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726748AbeJYRPQ (ORCPT ); Thu, 25 Oct 2018 13:15:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 06097B03C; Thu, 25 Oct 2018 08:43:28 +0000 (UTC) Date: Thu, 25 Oct 2018 10:43:27 +0200 From: Michal Hocko To: Uladzislau Rezki Cc: Joel Fernandes , Shuah Khan , Matthew Wilcox , Kees Cook , Andrew Morton , linux-mm@kvack.org, LKML , Thomas Garnier , Oleksiy Avramchenko , Steven Rostedt , Joel Fernandes , Thomas Gleixner , Ingo Molnar , Tejun Heo , maco@android.com Subject: Re: [RFC PATCH 0/2] improve vmalloc allocation Message-ID: <20181025084327.GN18839@dhcp22.suse.cz> References: <20181022125142.GD18839@dhcp22.suse.cz> <20181022165253.uphv3xzqivh44o3d@pc636> <20181023072306.GN18839@dhcp22.suse.cz> <20181023152640.GD20085@bombadil.infradead.org> <20181023170532.GW18839@dhcp22.suse.cz> <98842edb-d462-96b1-311f-27c6ebfc108a@kernel.org> <20181023193044.GA139403@joelaf.mtv.corp.google.com> <20181024062252.GA18839@dhcp22.suse.cz> <20181024173418.2bxkdjbcyzfkgfeu@pc636> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181024173418.2bxkdjbcyzfkgfeu@pc636> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 24-10-18 19:34:18, Uladzislau Rezki wrote: > Hi. > > On Wed, Oct 24, 2018 at 08:22:52AM +0200, Michal Hocko wrote: > > On Tue 23-10-18 12:30:44, Joel Fernandes wrote: > > > On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: > > > > On 10/23/2018 11:05 AM, Michal Hocko wrote: > > > > > On Tue 23-10-18 08:26:40, Matthew Wilcox wrote: > > > > >> On Tue, Oct 23, 2018 at 09:02:56AM -0600, Shuah Khan wrote: > > > > > [...] > > > > >>> The way it can be handled is by adding a test module under lib. test_kmod, > > > > >>> test_sysctl, test_user_copy etc. > > > > >> > > > > >> The problem is that said module can only invoke functions which are > > > > >> exported using EXPORT_SYMBOL. And there's a cost to exporting them, > > > > >> which I don't think we're willing to pay, purely to get test coverage. > > > > > > > > > > Yes, I think we do not want to export internal functionality which might > > > > > be still interesting for the testing coverage. Maybe we want something > > > > > like EXPORT_SYMBOL_KSELFTEST which would allow to link within the > > > > > kselftest machinery but it wouldn't allow the same for general modules > > > > > and will not give any API promisses. > > > > > > > > > > > > > I like this proposal. I think we will open up lot of test opportunities with > > > > this approach. > > > > > > > > Maybe we can use this stress test as a pilot and see where it takes us. > > > > > > I am a bit worried that such an EXPORT_SYMBOL_KSELFTEST mechanism can be abused by > > > out-of-tree module writers to call internal functionality. > > > > > > How would you prevent that? > > > > There is no way to prevent non-exported symbols abuse by 3rd party > > AFAIK. EXPORT_SYMBOL_* is not there to prohibid abuse. It is a mere > > signal of what is, well, an exported API. > > Can we just use kallsyms_lookup_name()? Heh, this is the abuse I've had in mind ;) > > static void *((*__my_vmalloc_node_range)(unsigned long size, > unsigned long align,unsigned long start, unsigned long end, > gfp_t gfp_mask,pgprot_t prot, unsigned long vm_flags, > int node, const void *caller)); > > __my_vmalloc_node_range = (void *) kallsyms_lookup_name("__vmalloc_node_range"); > This is just too ugly to live. So I would go with it only if there is no reasonable way to export what tests need with a sane interface. -- Michal Hocko SUSE Labs