From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: mazziesaccount@gmail.com, lgirdwood@gmail.com, broonie@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: bd718x7: add missing linux/of.h inclusion
Date: Mon, 29 Oct 2018 11:40:41 +0200 [thread overview]
Message-ID: <20181029094041.GB20774@localhost.localdomain> (raw)
In-Reply-To: <20180919071400.GA12191@localhost.localdomain>
Hello Mark,
I see we got build warning from 0-Day tests. It seems to me the
bd718x7.c file lacks of <linux/of.h> inclusion.
I am not sure what has happened as this include was added to bd71837.c
file with commit
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?h=for-next&id=df43519eb706edfe951284a825642ce2e1d38d09
The bd71837.c was later renamed to bd718x7.c with
commit
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/drivers/regulator?h=for-next&id=2ece646c90c5b45dd76c76ea207a3f3459f2c472
So I am not sure where this include got lost. (I did search for all log
entries with my name and was not able to spot this change)
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/log/drivers/regulator?h=for-next&qt=grep&q=Vaittinen
Should I just create another patch to you where this inclusion is done again
or is there some better way to handle this? Can you cherry pick or
re-apply the commit
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?h=for-next&id=df43519eb706edfe951284a825642ce2e1d38d09
- even though the file was later renamed?
Br,
Matti Vaittinen
--
Matti Vaittinen
ROHM Semiconductors
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
next prev parent reply other threads:[~2018-10-29 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 7:14 [PATCH] regulator: bd718x7: add missing linux/of.h inclusion Matti Vaittinen
2018-10-29 9:40 ` Matti Vaittinen [this message]
2018-10-29 9:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029094041.GB20774@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox