From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Colin King <colin.king@canonical.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES
Date: Mon, 29 Oct 2018 10:20:01 -0300 [thread overview]
Message-ID: <20181029132001.GD21857@kernel.org> (raw)
In-Reply-To: <20181029123656.GB57235@gmail.com>
Em Mon, Oct 29, 2018 at 01:36:56PM +0100, Ingo Molnar escreveu:
>
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> > Em Mon, Oct 29, 2018 at 09:28:54AM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Oct 26, 2018 at 06:58:39PM +0100, Colin King escreveu:
> > > > From: Colin Ian King <colin.king@canonical.com>
> > > >
> > > > Trivial fix to a spelling mistake of the error access name EACCESS,
> > > > rename to EACCES
> > >
> > > Thanks, applied.
> > >
> > > And I also took the chance to fix another spelling mistake, on this same
> > > line:
> > >
> > > - * -EACCESS -- @event is for this PMU, @event is valid, but no privilidges
> > > + * -EACCES -- @event is for this PMU, @event is valid, but no privilidges
> > > ^
> > > ^
> > > ^
> > > ^
> >
> > But I see Ingo has already merged your patch, lets fix that one later
> > then :-)
>
> I zapped my commit, please let's merge your upgraded version.
>
> BTW., while at it, could we also try a header refresh now that a lot of
> the merge window changes to headers are behind us, this is from the
> perf/urgent build (f0718d792b8a)"
>
> Warning: Kernel ABI header at 'tools/include/uapi/linux/kvm.h' differs from latest version at 'include/uapi/linux/kvm.h'
> diff -u tools/include/uapi/linux/kvm.h include/uapi/linux/kvm.h
> Warning: Kernel ABI header at 'tools/include/uapi/sound/asound.h' differs from latest version at 'include/uapi/sound/asound.h'
> diff -u tools/include/uapi/sound/asound.h include/uapi/sound/asound.h
> Warning: Kernel ABI header at 'tools/arch/x86/include/asm/cpufeatures.h' differs from latest version at 'arch/x86/include/asm/cpufeatures.h'
> diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures.h
> Warning: Kernel ABI header at 'tools/arch/x86/include/uapi/asm/kvm.h' differs from latest version at 'arch/x86/include/uapi/asm/kvm.h'
> diff -u tools/arch/x86/include/uapi/asm/kvm.h arch/x86/include/uapi/asm/kvm.h
> Warning: Kernel ABI header at 'tools/arch/powerpc/include/uapi/asm/kvm.h' differs from latest version at 'arch/powerpc/include/uapi/asm/kvm.h'
> diff -u tools/arch/powerpc/include/uapi/asm/kvm.h arch/powerpc/include/uapi/asm/kvm.h
> Warning: Kernel ABI header at 'tools/arch/s390/include/uapi/asm/kvm.h' differs from latest version at 'arch/s390/include/uapi/asm/kvm.h'
> diff -u tools/arch/s390/include/uapi/asm/kvm.h arch/s390/include/uapi/asm/kvm.h
> Warning: Kernel ABI header at 'tools/arch/arm64/include/uapi/asm/unistd.h' differs from latest version at 'arch/arm64/include/uapi/asm/unistd.h'
> diff -u tools/arch/arm64/include/uapi/asm/unistd.h arch/arm64/include/uapi/asm/unistd.h
> Warning: Kernel ABI header at 'tools/include/uapi/asm-generic/unistd.h' differs from latest version at 'include/uapi/asm-generic/unistd.h'
> diff -u tools/include/uapi/asm-generic/unistd.h include/uapi/asm-generic/unistd.h
> Warning: Kernel ABI header at 'tools/include/uapi/linux/mman.h' differs from latest version at 'include/uapi/linux/mman.h'
> diff -u tools/include/uapi/linux/mman.h include/uapi/linux/mman.h
>
> ?
>
> Thanks!
Ok, I'll put together a perf/urgent with those things resolved, may take
a day or two as I'm working on addressing DaveM's reported issues and in
fixing the regressions that that "remove fallback to kallsyms for
userspace addresses" patch caused.
- Arnaldo
next prev parent reply other threads:[~2018-10-29 13:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 17:58 [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES Colin King
2018-10-29 11:35 ` [tip:perf/urgent] perf/headers: Fix spelling mistake in <linux/perf_event.h> comment, " tip-bot for Colin Ian King
2018-10-29 12:28 ` [PATCH] drivers/perf: fix spelling mistake, " Arnaldo Carvalho de Melo
2018-10-29 12:33 ` Colin Ian King
2018-10-29 12:33 ` Arnaldo Carvalho de Melo
2018-10-29 12:36 ` Ingo Molnar
2018-10-29 13:20 ` Arnaldo Carvalho de Melo [this message]
2018-10-29 14:19 ` Ingo Molnar
2018-10-29 12:35 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029132001.GD21857@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=colin.king@canonical.com \
--cc=jolsa@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox