Re: [PATCH AUTOSEL 4.14 17/19] selftests: ftrace: Add synthetic event syntax testcase

Masami Hiramatsu
2018-11-01T17:34:22Z

On Tue, 30 Oct 2018 14:21:12 -0400
Sasha Levin <sashal@kernel.org> wrote:

> On Tue, Oct 30, 2018 at 10:58:15AM -0400, Steven Rostedt wrote:
> >On Tue, 30 Oct 2018 09:28:22 -0400
> >Sasha Levin <sashal@kernel.org> wrote:
> >
> >> From: Masami Hiramatsu <mhiramat@kernel.org>
> >>
> >> [ Upstream commit ba0e41ca81b935b958006c7120466e2217357827 ]
> >>
> >> Add a testcase to check the syntax and field types for
> >> synthetic_events interface.
> >>
> >> Link: http://lkml.kernel.org/r/153986838264.18251.16627517536956299922.stgit@devbox
> >>
> >> Acked-by: Shuah Khan <shuah@kernel.org>
> >> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> >> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >> Signed-off-by: Sasha Levin <sashal@kernel.org>
> >
> >Why are you adding selftests for old kernels to test a feature that
> >wasn't added until 4.17?
>
> We backport all selftest patches to stable to keep selftest on stable
> kernels as similar as possible to upstream.

Hi Sasha,
Yes, you can feel free to backport selftests fix, but also please backport
corresponding bugfix patches. Unless it, the stable tree will fail the test.

Thank you,

--
Masami Hiramatsu <mhiramat@kernel.org>