From: Sasha Levin <sashal@kernel.org>
To: Shayenne Moura <shayenneluzmoura@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>,
Michael Thayer <michael.thayer@oracle.com>,
devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses
Date: Tue, 30 Oct 2018 19:48:26 -0400 [thread overview]
Message-ID: <20181030234826.GE194472@sasha-vm> (raw)
In-Reply-To: <20181030231757.24ooubt25oykmgkt@smtp.gmail.com>
On Tue, Oct 30, 2018 at 08:17:57PM -0300, Shayenne Moura wrote:
>On 10/30, Greg Kroah-Hartman wrote:
>> On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote:
>> > Remove unneeded parentheses around the arguments of ||. This reduces
>> > clutter and code behave in the same way.
>> > Change suggested by checkpatch.pl.
>> >
>> > vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
>> > crtc->x'
>> >
>> > Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>
>> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> > ---
>> > Changes in v2:
>> > - Make the commit message more clearer.
>>
>> This patch does not apply to the latest kernel tree at all :(
>>
>> Please fix up and resend.
>>
>> thanks,
>>
>> greg k-h
>
>Hi Greg!
>
>Sorry, I do not know what branch are expected to be used.
>I used the drm-misc-next to create this patch and I could not
>find any merge problem.
>
>Could you please tell me the details?
Hi Shayenne,
There's an easy trick for this: the kernel tree has a script that can
help you find both the relevant maintainers, and their development tree
for each file in the kernel.
Simply run:
./scripts/get_maintainer.pl --scm -f [filename]
For example, in this case, you'd run:
$ ./scripts/get_maintainer.pl --scm -f drivers/staging/vboxvideo/vbox_main.c
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:STAGING SUBSYSTEM,commit_signer:10/10=100%)
Hans de Goede <hdegoede@redhat.com> (commit_signer:7/10=70%,authored:6/10=60%,added_lines:31/37=84%,removed_lines:153/159=96%)
Fabio Rafael da Rosa <fdr@pid42.net> (commit_signer:1/10=10%,authored:1/10=10%)
Alexander Kapshuk <alexander.kapshuk@gmail.com> (commit_signer:1/10=10%,authored:1/10=10%)
Nicholas Mc Guire <der.herr@hofr.at> (commit_signer:1/10=10%)
Thomas Zimmermann <tzimmermann@suse.de> (authored:1/10=10%,added_lines:2/37=5%)
Daniel Junho <djunho@gmail.com> (authored:1/10=10%,added_lines:2/37=5%)
devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)
git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
The list of people and mailing lists are the ones that should be the
recipients of your patch, and the last line is the git tree on which the
patch should be based on.
--
Thanks,
Sasha
next prev parent reply other threads:[~2018-10-30 23:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 17:43 [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses Shayenne da Luz Moura
2018-10-26 11:11 ` Hans de Goede
2018-10-30 9:25 ` Greg Kroah-Hartman
2018-10-30 23:17 ` Shayenne Moura
2018-10-30 23:48 ` Sasha Levin [this message]
2018-10-31 15:05 ` [Outreachy kernel] " Shayenne Moura
2018-10-31 6:06 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030234826.GE194472@sasha-vm \
--to=sashal@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thayer@oracle.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=shayenneluzmoura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox