linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Andi Kleen <ak@linux.intel.com>,
	linux-kernel@vger.kernel.org, leo.yan@linaro.org,
	David Miller <davem@davemloft.net>,
	Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: [PATCH 2/5] perf tools: Use fallback for sample_addr_correlates_sym() cases
Date: Wed, 31 Oct 2018 11:10:40 +0200	[thread overview]
Message-ID: <20181031091043.23465-3-adrian.hunter@intel.com> (raw)
In-Reply-To: <20181031091043.23465-1-adrian.hunter@intel.com>

thread__resolve() is used in the sample_addr_correlates_sym() cases where
'addr' is a destination of a branch which does not necessarily have the
same cpumode as the 'ip'. Use the fallback function in that case.

This patch depends on patch "perf tools: Add fallback functions for cases
where cpumode is insufficient".

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org # 4.19
---
 tools/perf/util/event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 52b24b8ce29e..316f62ffa27b 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -1705,7 +1705,7 @@ bool sample_addr_correlates_sym(struct perf_event_attr *attr)
 void thread__resolve(struct thread *thread, struct addr_location *al,
 		     struct perf_sample *sample)
 {
-	thread__find_map(thread, sample->cpumode, sample->addr, al);
+	thread__find_map_fallback(thread, sample->cpumode, sample->addr, al);
 
 	al->cpu = sample->cpu;
 	al->sym = NULL;
-- 
2.17.1


  parent reply	other threads:[~2018-10-31  9:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31  9:10 [PATCH 0/5] perf tools: Fix for cases where cpumode is incorrect or insufficient Adrian Hunter
2018-10-31  9:10 ` [PATCH 1/5] perf tools: Add fallback functions for cases where cpumode is insufficient Adrian Hunter
2018-11-05 17:29   ` Arnaldo Carvalho de Melo
2018-11-05 18:19     ` David Miller
2018-11-05 19:21     ` Hunter, Adrian
2018-11-05 19:36       ` Arnaldo Carvalho de Melo
2018-11-05 19:53         ` Hunter, Adrian
2018-11-05 20:31           ` Arnaldo Carvalho de Melo
2018-11-26 19:02           ` Arnaldo Carvalho de Melo
2018-11-26 19:41             ` Arnaldo Carvalho de Melo
2018-11-26 19:44               ` Arnaldo Carvalho de Melo
2018-10-31  9:10 ` Adrian Hunter [this message]
2018-11-03 17:46   ` [PATCH 2/5] perf tools: Use fallback for sample_addr_correlates_sym() cases Hunter, Adrian
2018-10-31  9:10 ` [PATCH 3/5] perf tools: Use fallbacks for branch stacks Adrian Hunter
2018-11-05 17:56   ` Arnaldo Carvalho de Melo
2018-10-31  9:10 ` [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains Adrian Hunter
2018-10-31 13:28   ` Arnaldo Carvalho de Melo
2018-10-31 14:15     ` Adrian Hunter
2018-10-31 14:20       ` Adrian Hunter
2018-10-31 14:27         ` Arnaldo Carvalho de Melo
2018-10-31 22:12         ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2018-10-31 14:26       ` [PATCH 4/5] " Arnaldo Carvalho de Melo
2018-10-31  9:10 ` [PATCH 5/5] perf intel-pt/bts: Calculate cpumode for synthesized samples Adrian Hunter
2018-10-31 22:13   ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2018-10-31 13:35 ` [PATCH 0/5] perf tools: Fix for cases where cpumode is incorrect or insufficient Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031091043.23465-3-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).