From: "J. Bruce Fields" <bfields@fieldses.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-nfs@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jlayton@redhat.com
Subject: Re: [GIT PULL] nfsd changes for 4.20
Date: Wed, 31 Oct 2018 11:44:18 -0400 [thread overview]
Message-ID: <20181031154418.GB2451@fieldses.org> (raw)
In-Reply-To: <CAHk-=wgeJzBWjCafB3nKP0QMJCyh3rAjN+s6Z+T+5hfAT81YMw@mail.gmail.com>
On Tue, Oct 30, 2018 at 01:06:58PM -0700, Linus Torvalds wrote:
> On Tue, Oct 30, 2018 at 12:55 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Pulled,
>
> Oh, I take that back. Semantic conflict with locking name change
> (recv_lock -> queue_lock) and new code in
>
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c
>
> exposed by my build test.
>
> And looking around, it was reported in linux-next, but you didn't
> mention it, which kind of makes the whole reporting pointless.
>
> Guys, what is the point of linux-next if you then don't *react* to it?
> The correct reaction is to say during the merge window that "hey,
> linux-next showed this issue", just so that I know about it and it
> doesn't take me by surprise.
>
> Yes, my normal build tests caught it, and I've fixed up my merge, but
> this isn't how things are supposed to work.
Apologies, thanks for the correction.
I see Stephen Rothwell's message from October 5. I think at the time I
said "OK, looks minor, just something to mention in the pull request",
then forgot about it.
In future when that happens, I'll add some kind of reminder to my
request-pull script.
Stephen also sent a warning about a merge conflict with the vfs tree
(not merged yet, I think) but I assume that's not as big a deal since it
should actually show up at merge time, not build time:
http://lkml.kernel.org/r/20181029122121.7758fed4@canb.auug.org.au
--b.
next prev parent reply other threads:[~2018-10-31 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 19:17 [GIT PULL] nfsd changes for 4.20 J. Bruce Fields
2018-10-30 19:55 ` Linus Torvalds
2018-10-30 20:06 ` Linus Torvalds
2018-10-31 15:44 ` J. Bruce Fields [this message]
2018-10-31 15:53 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031154418.GB2451@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox