From: Ingo Molnar <mingo@kernel.org>
To: "Chang S. Bae" <chang.seok.bae@intel.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ravi Shankar <ravi.v.shankar@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86/fsgsbase/64: Fix the base write helper functions
Date: Thu, 1 Nov 2018 11:15:17 +0100 [thread overview]
Message-ID: <20181101101517.GA108479@gmail.com> (raw)
In-Reply-To: <20181031185351.9736-1-chang.seok.bae@intel.com>
* Chang S. Bae <chang.seok.bae@intel.com> wrote:
> Factor out the code to change index from the relavant helpers. Now,
> the code is located in do_arch_prctl_64().
typo.
>
> The helper functions that purport to write the base should just write it
> only. It shouldn't have magic optimizations to change the index.
>
> putreg() in ptrace does not write the current task, but a stopped task.
>
> v2: Fix further on the task write functions. Revert the changes on the
> task read helpers.
>
> Suggested-by: Andy Lutomirski <luto@kernel.org>
> Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
But most importantly, the changelog is confusing: please start the
changelog with outlining the problem in an easy to digest fashion,
starting with the highest level problem description and then successively
iterating down towards the details.
The title says 'fix' so I suppose this fixes something, it doesn't just
'factor out'?
Thanks,
Ingo
prev parent reply other threads:[~2018-11-01 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 18:53 [PATCH v2] x86/fsgsbase/64: Fix the base write helper functions Chang S. Bae
2018-11-01 10:15 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101101517.GA108479@gmail.com \
--to=mingo@kernel.org \
--cc=ak@linux.intel.com \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox