From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: bigeasy@linutronix.de
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: rcu: make RCU_BOOST default on RT
Date: Thu, 1 Nov 2018 16:25:18 -0700 [thread overview]
Message-ID: <20181101232518.GA12385@linux.ibm.com> (raw)
> Since it is no longer invoked from the softirq people run into OOM more
> often if the priority of the RCU thread is too low. Making boosting
> default on RT should help in those case and it can be switched off if
> someone knows better.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> diff --git a/kernel/rcu/Kconfig b/kernel/rcu/Kconfig
> index 644264be90f0..0be2c96fb640 100644
> --- a/kernel/rcu/Kconfig
> +++ b/kernel/rcu/Kconfig
> @@ -36,7 +36,7 @@ config TINY_RCU
>
> config RCU_EXPERT
> bool "Make expert-level adjustments to RCU configuration"
> - default n
> + default y if PREEMPT_RT_FULL
Would it work to leave this as is, and ...
> help
> This option needs to be enabled if you wish to make
> expert-level adjustments to RCU configuration. By default,
> @@ -191,7 +191,7 @@ config RCU_FAST_NO_HZ
> config RCU_BOOST
> bool "Enable RCU priority boosting"
> depends on RT_MUTEXES && PREEMPT_RCU && RCU_EXPERT
... make the above line instead be:
depends on (RT_MUTEXES && PREEMPT_RCU && RCU_EXPERT) || PREEMPT_RT_FULL
Or am I missing something?
I agree that the risk might currently seem small, but if Linus ever
starts building PREEMPT_RT_FULL kernels, I really really do not want
RCU_EXPERT to be set. ;-)
Thanx, Paul
> - default n
> + default y if PREEMPT_RT_FULL
> help
> This option boosts the priority of preempted RCU readers that
> block the current preemptible RCU grace period for too long.
next reply other threads:[~2018-11-01 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 23:25 Paul E. McKenney [this message]
2018-11-08 16:05 ` rcu: make RCU_BOOST default on RT Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101232518.GA12385@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox