linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] perf: Remove strchr() in map__process_kallsyms_symbol().
@ 2018-11-03  6:00 David Miller
  0 siblings, 0 replies; only message in thread
From: David Miller @ 2018-11-03  6:00 UTC (permalink / raw)
  To: acme; +Cc: linux-kernel


This is looking for '[vdso]', '[vsyscall]' or similar to
force the "kernel" boolean arg to __symbols__insert() to
false.

But such things never show up in kallsyms.

This check was added by commit 608c34de0b3d ("perf symbols: Mark if a
symbol is idle in the library")

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 tools/perf/util/symbol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index d188b7588152..345d66d745d1 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -660,7 +660,7 @@ static int map__process_kallsym_symbol(void *arg, const char *name,
 	 * We will pass the symbols to the filter later, in
 	 * map__split_kallsyms, when we have split the maps per module
 	 */
-	__symbols__insert(root, sym, !strchr(name, '['));
+	__symbols__insert(root, sym, true);
 
 	return 0;
 }
-- 
2.19.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-11-03  6:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-03  6:00 [PATCH] perf: Remove strchr() in map__process_kallsyms_symbol() David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).