From: David Miller <davem@davemloft.net>
To: malat@debian.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: move ‘__zerocopy_sg_from_iter’ prototype to header file <linux/skbuff.h>
Date: Fri, 02 Nov 2018 23:33:57 -0700 (PDT) [thread overview]
Message-ID: <20181102.233357.1129560140046922258.davem@davemloft.net> (raw)
In-Reply-To: <20181031113500.3763-1-malat@debian.org>
From: Mathieu Malaterre <malat@debian.org>
Date: Wed, 31 Oct 2018 12:34:59 +0100
> This makes it clear the function is part of the API. Also this will
> remove a warning triggered at W=1:
>
> net/core/datagram.c:581:5: warning: no previous prototype for ‘__zerocopy_sg_from_iter’ [-Wmissing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
It's not part of the "API", and it shouldn't even be exported to
modules.
Only net/core/skbuff.c calls it, and that is never modular.
next prev parent reply other threads:[~2018-11-03 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 11:34 [PATCH] net: move ‘__zerocopy_sg_from_iter’ prototype to header file <linux/skbuff.h> Mathieu Malaterre
2018-11-03 6:33 ` David Miller [this message]
2018-11-05 20:20 ` Mathieu Malaterre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102.233357.1129560140046922258.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=malat@debian.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).