Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks

Shawn Guo
2018-11-13T14:42:23Z

On Mon, Nov 05, 2018 at 10:12:30AM +0100, Martin Kaiser wrote:
> Hi,
>
> Thus wrote Shawn Guo (shawnguo@kernel.org):
>
> > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote:
> > > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer)
> > > function blocks. Add their ipg and per clocks to the device tree.
>
> > > Signed-off-by: Martin Kaiser <martin@kaiser.cx>
>
> > Are these EPIT devices actually used in upstream kernel, or just
> > somewhere else?
>
> Until I saw Vladimir's mail this morning, I wasn't aware of any mainline
> driver that's using the EPIT devices. I found that the clocks are
> missing when I tried to use EPIT with a company-internal driver that's
> not suitable for mainline integration.
>
> Still, I think that merging this patch does no harm. If the EPIT devices
> are present in the DT, we should add all resources they're using.

Agreed. I will be happy to apply the patch if I can get an ACK from
Clément saying this works with his driver in upstreaming.

Shawn