From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F6F1C32789 for ; Sun, 4 Nov 2018 16:40:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 364A420854 for ; Sun, 4 Nov 2018 16:40:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="QrIsEDeg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 364A420854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731991AbeKEBzg (ORCPT ); Sun, 4 Nov 2018 20:55:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:36322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730885AbeKEBzg (ORCPT ); Sun, 4 Nov 2018 20:55:36 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 825AD2081D; Sun, 4 Nov 2018 16:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541349603; bh=swtRxHhOWoMa0QdSwez6PwgQcT4c5I7WzmVvb2eGmYs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QrIsEDegWivTXWTALPg1NIqr/eGzYCGXDkkCFm0Ijis9rl3w9VoFvVu1ChZcUru3S NTENiB/0ZRCPDlLOl+q80FE+66F83hVJSXDzL1dI6Ro51kQJxHEsooMbOEIXE0Dclm 3sVHECG3An8MQ3rKOp/FQH/xZViWp4bIq4p5IRLI= Date: Sun, 4 Nov 2018 16:39:58 +0000 From: Jonathan Cameron To: Matheus Tavares Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: Re: [PATCH v3 3/6] staging:iio:ad2s90: Remove always overwritten assignment Message-ID: <20181104163958.1cb8f615@archlinux> In-Reply-To: <20181103224948.31014-4-matheus.bernardino@usp.br> References: <20181103224948.31014-1-matheus.bernardino@usp.br> <20181103224948.31014-4-matheus.bernardino@usp.br> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 3 Nov 2018 19:49:45 -0300 Matheus Tavares wrote: > This patch removes an initial assignment to the variable ret at probe, > that was always overwritten. > > Signed-off-by: Matheus Tavares Applied to the togreg branch of iio.git and pushed out as testing to see if we are both wrong and there is something wrong with it that build tests and static analysers can find! Thanks, Jonathan > --- > drivers/staging/iio/resolver/ad2s90.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c > index 4908c8a95fad..54ad85bd9dc6 100644 > --- a/drivers/staging/iio/resolver/ad2s90.c > +++ b/drivers/staging/iio/resolver/ad2s90.c > @@ -62,7 +62,7 @@ static int ad2s90_probe(struct spi_device *spi) > { > struct iio_dev *indio_dev; > struct ad2s90_state *st; > - int ret = 0; > + int ret; > > indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); > if (!indio_dev)