From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] s390: numa: Export __node_distance
Date: Mon, 5 Nov 2018 07:08:55 +0100 [thread overview]
Message-ID: <20181105060855.GA3747@osiris> (raw)
In-Reply-To: <1541366886-32127-1-git-send-email-linux@roeck-us.net>
On Sun, Nov 04, 2018 at 01:28:06PM -0800, Guenter Roeck wrote:
> __node_distance is used by nvme, resulting in:
>
> ERROR: "__node_distance" [drivers/nvme/host/nvme-core.ko] undefined!
>
> when trying to build nvme as module.
>
> Fixes: f333444708f8 ("nvme: take node locality into account when selecting a path")
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> I thought I had seen that patch already, but I don't find it anywhere.
> Maybe that was for another architecture. My apologies for the noise if it
> is already queued.
It's already queued here: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h=for-linus&id=a541f0ebcc08ed8bc0cc492eec9a86cb280a9f24
> diff --git a/arch/s390/numa/numa.c b/arch/s390/numa/numa.c
> index ae0d9e889534..d31bde0870d8 100644
> --- a/arch/s390/numa/numa.c
> +++ b/arch/s390/numa/numa.c
> @@ -53,6 +53,7 @@ int __node_distance(int a, int b)
> {
> return mode->distance ? mode->distance(a, b) : 0;
> }
> +EXPORT_SYMBOL(__node_distance);
prev parent reply other threads:[~2018-11-05 6:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 21:28 [PATCH] s390: numa: Export __node_distance Guenter Roeck
2018-11-05 6:08 ` Martin Schwidefsky
2018-11-05 6:08 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105060855.GA3747@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox