From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EC82ECDE44 for ; Mon, 5 Nov 2018 09:17:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D696420862 for ; Mon, 5 Nov 2018 09:17:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D696420862 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728997AbeKESgR (ORCPT ); Mon, 5 Nov 2018 13:36:17 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46035 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726173AbeKESgR (ORCPT ); Mon, 5 Nov 2018 13:36:17 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 68CAF80805; Mon, 5 Nov 2018 10:17:28 +0100 (CET) Date: Mon, 5 Nov 2018 10:17:30 +0100 From: Pavel Machek To: Lubomir Rintel Cc: Mauro Carvalho Chehab , Jonathan Corbet , linux-media@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, James Cameron Subject: Re: [PATCH 08/11] [media] marvell-ccic/mmp: enable clock before accessing registers Message-ID: <20181105091730.GB4439@amd> References: <20181105073054.24407-1-lkundrak@v3.sk> <20181105073054.24407-9-lkundrak@v3.sk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IrhDeMKUP4DT/M7F" Content-Disposition: inline In-Reply-To: <20181105073054.24407-9-lkundrak@v3.sk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IrhDeMKUP4DT/M7F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2018-11-05 08:30:51, Lubomir Rintel wrote: > The access to REG_CLKCTRL or REG_CTRL1 without the clock enabled hangs > the machine. Enable the clock first. >=20 > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > --- > drivers/media/platform/marvell-ccic/mmp-driver.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/m= edia/platform/marvell-ccic/mmp-driver.c > index 9e988e527b0d..9c0238f72c40 100644 > --- a/drivers/media/platform/marvell-ccic/mmp-driver.c > +++ b/drivers/media/platform/marvell-ccic/mmp-driver.c > @@ -145,6 +145,7 @@ static int mmpcam_power_up(struct mcam_camera *mcam) > * Turn on power and clocks to the controller. > */ > mmpcam_power_up_ctlr(cam); > + mcam_clk_enable(mcam); > /* > * Provide power to the sensor. > */ > @@ -158,8 +159,6 @@ static int mmpcam_power_up(struct mcam_camera *mcam) > gpio_set_value(pdata->sensor_reset_gpio, 1); /* reset is active low */ > mdelay(5); > =20 > - mcam_clk_enable(mcam); > - > return 0; > } > =20 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --IrhDeMKUP4DT/M7F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlvgCqoACgkQMOfwapXb+vKVKgCeNOiPzU9OYhyuKCSuVwM+6deQ b2QAn0dDiYxxa40Iv9wPHEj+r2xHx2Qz =opxu -----END PGP SIGNATURE----- --IrhDeMKUP4DT/M7F--