public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: X86 ML <x86@kernel.org>, Mike Rapoport <rppt@linux.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/gart: Rewrite early_gart_iommu_check() comment
Date: Mon, 5 Nov 2018 16:35:40 +0100	[thread overview]
Message-ID: <20181105153540.GA89305@gmail.com> (raw)
In-Reply-To: <20181101155314.30690-1-bp@alien8.de>


* Borislav Petkov <bp@alien8.de> wrote:

> From: Borislav Petkov <bp@suse.de>
> 
> ... to actually explain what the function is trying to do.
> 
> Reported-by: Mike Rapoport <rppt@linux.ibm.com>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
>  arch/x86/kernel/aperture_64.c | 25 +++++++++++++++----------
>  1 file changed, 15 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
> index 2c4d5ece7456..4fb4b7f53568 100644
> --- a/arch/x86/kernel/aperture_64.c
> +++ b/arch/x86/kernel/aperture_64.c
> @@ -264,18 +264,23 @@ static int __init parse_gart_mem(char *p)
>  }
>  early_param("gart_fix_e820", parse_gart_mem);
>  
> +/*
> + * With kexec/kdump, if the first kernel doesn't shutdown the GART and the
> + * second kernel allocates a different GART region, there might be two
> + * overlapping GART regions present:

s/shutdown
 /shut down

Thanks,

	Ingo

  parent reply	other threads:[~2018-11-05 15:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 15:53 [PATCH] x86/gart: Rewrite early_gart_iommu_check() comment Borislav Petkov
2018-11-01 17:09 ` Thomas Gleixner
2018-11-05 13:39 ` [tip:x86/cleanups] " tip-bot for Borislav Petkov
2018-11-05 15:35 ` Ingo Molnar [this message]
2018-11-05 20:20   ` [PATCH] " Borislav Petkov
2018-11-05 20:24 ` [tip:x86/cleanups] " tip-bot for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105153540.GA89305@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rppt@linux.ibm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox