Re: [PATCH v3 02/16] tpm: fix invalid return value in pubek_show()

Stefan Berger
2018-11-05T21:51:15Z

On 11/4/18 8:45 PM, Jarkko Sakkinen wrote:
> Return zero when tpm_buf_init() fails as we do for other functions in
> tpm-sysfs.c.
>
> Fixes: da379f3c1db0c ("tpm: migrate pubek_show to struct tpm_buf")
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>

> ---
> drivers/char/tpm/tpm-sysfs.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c
> index c2769e55cb6c..7ed7eb6f906a 100644
> --- a/drivers/char/tpm/tpm-sysfs.c
> +++ b/drivers/char/tpm/tpm-sysfs.c
> @@ -47,9 +47,8 @@ static ssize_t pubek_show(struct device *dev, struct device_attribute *attr,
>
> memset(&anti_replay, 0, sizeof(anti_replay));
>
> - rc = tpm_buf_init(&tpm_buf, TPM_TAG_RQU_COMMAND, TPM_ORD_READPUBEK);
> - if (rc)
> - return rc;
> + if (tpm_buf_init(&tpm_buf, TPM_TAG_RQU_COMMAND, TPM_ORD_READPUBEK))
> + return 0;
>
> tpm_buf_append(&tpm_buf, anti_replay, sizeof(anti_replay));
>