From: Alexey Dobriyan <adobriyan@gmail.com>
To: willy@infradead.org
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
linux-arch@vger.kernel.org
Subject: Re: + fls-change-parameter-to-unsigned-int.patch added to -mm tree
Date: Tue, 6 Nov 2018 18:14:44 +0300 [thread overview]
Message-ID: <20181106151444.GA11221@avx2> (raw)
In-Reply-To: <20181105233301.KlgdF%akpm@linux-foundation.org>
On Mon, Nov 05, 2018 at 03:33:01PM -0800, akpm@linux-foundation.org wrote:
> -static inline int fls(int x)
> +static inline int fls(unsigned int x)
> {
> - return fls64((unsigned int) x);
> + return fls64(x);
> }
Should it return "unsigned"? Logically it should.
I remember doing this and there was some code size increase :-(
next parent reply other threads:[~2018-11-06 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181105233301.KlgdF%akpm@linux-foundation.org>
2018-11-06 15:14 ` Alexey Dobriyan [this message]
2018-11-06 15:44 ` + fls-change-parameter-to-unsigned-int.patch added to -mm tree Matthew Wilcox
2018-11-06 17:01 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106151444.GA11221@avx2 \
--to=adobriyan@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox