From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Claudiu.Beznea@microchip.com
Cc: sre@kernel.org, Nicolas.Ferre@microchip.com,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] power: reset: at91-poweroff: move shdwc related data to one structure
Date: Tue, 6 Nov 2018 22:09:33 +0100 [thread overview]
Message-ID: <20181106210933.GU24212@piout.net> (raw)
In-Reply-To: <1541416443-4321-3-git-send-email-claudiu.beznea@microchip.com>
Hi Claudiu,
On 05/11/2018 11:14:26+0000, Claudiu.Beznea@microchip.com wrote:
> static int __init at91_poweroff_probe(struct platform_device *pdev)
> @@ -154,16 +160,22 @@ static int __init at91_poweroff_probe(struct platform_device *pdev)
> u32 ddr_type;
> int ret;
>
> + at91_shdwc = devm_kzalloc(&pdev->dev, sizeof(*at91_shdwc), GFP_KERNEL);
> + if (!at91_shdwc)
> + return -ENOMEM;
> +
Is there any real benefit that will offset the time lost for that
allocation at boot time?
I understand you are then testing at91_shdwc to know whether the driver
already probed once. But, the driver will never probe twice as there is
only one shutdown controller on the SoC and anyway, If it was to probe
twice, it will still work as expected.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-06 21:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 11:14 [PATCH 0/4] power: reset: at91-poweroff: cleanups Claudiu.Beznea
2018-11-05 11:14 ` [PATCH 1/4] power: reset: at91-poweroff: use one poweroff function for at91-poweroff Claudiu.Beznea
2018-12-05 22:37 ` Sebastian Reichel
2018-11-05 11:14 ` [PATCH 2/4] power: reset: at91-poweroff: move shdwc related data to one structure Claudiu.Beznea
2018-11-06 21:09 ` Alexandre Belloni [this message]
2018-11-07 14:54 ` Claudiu.Beznea
2018-11-07 17:23 ` Alexandre Belloni
2018-12-05 22:40 ` Sebastian Reichel
2018-12-06 9:48 ` Claudiu.Beznea
2018-11-05 11:14 ` [PATCH 3/4] power: reset: at91-poweroff: check shdwc data structure at the beginning of probe Claudiu.Beznea
2018-12-05 22:38 ` Sebastian Reichel
2018-11-05 11:14 ` [PATCH 4/4] power: reset: at91-poweroff: remove at91_ramc_of_match Claudiu.Beznea
2018-12-05 22:37 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106210933.GU24212@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox