From: Greg Kroah-Hartman <greg@kroah.com>
To: Jerry Lin <wahahab11@gmail.com>
Cc: "Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
astrachan@google.com, ghartman@google.com,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.
Date: Wed, 7 Nov 2018 10:15:04 +0100 [thread overview]
Message-ID: <20181107091504.GD31015@kroah.com> (raw)
In-Reply-To: <20181107023043.GA18052@ubuntu>
On Wed, Nov 07, 2018 at 10:30:43AM +0800, Jerry Lin wrote:
> Add a attribute called permissions under vsoc device node for examining
> current granted permissions in vsoc_device.
>
> This file will display permissions in following format:
> begin_offset end_offset owner_offset owned_value
> %x %x %x %x
>
> Signed-off-by: Jerry Lin <wahahab11@gmail.com>
> ---
> drivers/staging/android/vsoc.c | 48 +++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 45 insertions(+), 3 deletions(-)
What changed from v2? And where was v2? What about v1?
You need a change log here of what you did different from the previous
patches.
And why ignore my response saying that this type of sysfs file is not ok
at all?
thanks,
greg k-h
next prev parent reply other threads:[~2018-11-07 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 2:30 [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions Jerry Lin
2018-11-07 9:15 ` Greg Kroah-Hartman [this message]
2018-11-08 0:49 ` wahahab
2018-11-08 1:44 ` Greg Kroah-Hartman
2018-11-09 17:15 ` Dan Carpenter
[not found] ` <6ADC007E-85BB-4CA1-89FB-9254937E8C63@gmail.com>
2018-11-12 12:40 ` Greg Kroah-Hartman
2018-11-13 3:32 ` wahahab
2018-11-20 9:56 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107091504.GD31015@kroah.com \
--to=greg@kroah.com \
--cc=arve@android.com \
--cc=astrachan@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=ghartman@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=tkjos@android.com \
--cc=wahahab11@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox