* [PATCH] staging: mt7621-mmc: Add blank line after declaration
@ 2018-11-07 0:42 nicolas
2018-11-07 11:26 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: nicolas @ 2018-11-07 0:42 UTC (permalink / raw)
To: gregkh, linux, pure.logic, devel, linux-kernel, lkcamp
From: Nícolas F. R. A. Prado <nfraprado@protonmail.com>
Correct the following warning from checkpatch.pl:
WARNING: Missing a blank line after declarations
+ struct msdc_host *host = mmc_priv(mmc);
+ msdc_pm(state, (void *)host);
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@protonmail.com>
---
Hi, this is my first commit. Let me know if there's anything I can do
better.
---
drivers/staging/mt7621-mmc/sd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
index 0379f9c96..7b66f9b0a 100644
--- a/drivers/staging/mt7621-mmc/sd.c
+++ b/drivers/staging/mt7621-mmc/sd.c
@@ -1797,6 +1797,7 @@ static void msdc_drv_pm(struct platform_device *pdev, pm_message_t state)
if (mmc) {
struct msdc_host *host = mmc_priv(mmc);
+
msdc_pm(state, (void *)host);
}
}
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: mt7621-mmc: Add blank line after declaration
2018-11-07 0:42 [PATCH] staging: mt7621-mmc: Add blank line after declaration nicolas
@ 2018-11-07 11:26 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-11-07 11:26 UTC (permalink / raw)
To: nicolas; +Cc: linux, pure.logic, devel, linux-kernel, lkcamp
On Tue, Nov 06, 2018 at 10:42:42PM -0200, nicolas@autobyte.com.br wrote:
> From: Nícolas F. R. A. Prado <nfraprado@protonmail.com>
>
> Correct the following warning from checkpatch.pl:
>
> WARNING: Missing a blank line after declarations
> + struct msdc_host *host = mmc_priv(mmc);
> + msdc_pm(state, (void *)host);
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@protonmail.com>
>
> ---
>
> Hi, this is my first commit. Let me know if there's anything I can do
> better.
> ---
> drivers/staging/mt7621-mmc/sd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
> index 0379f9c96..7b66f9b0a 100644
> --- a/drivers/staging/mt7621-mmc/sd.c
> +++ b/drivers/staging/mt7621-mmc/sd.c
> @@ -1797,6 +1797,7 @@ static void msdc_drv_pm(struct platform_device *pdev, pm_message_t state)
>
> if (mmc) {
> struct msdc_host *host = mmc_priv(mmc);
> +
> msdc_pm(state, (void *)host);
> }
This patch is fine, and I'll take it, but can't this be written a lot
simpler:
if (mmc)
msdc_pm(state, mmc_priv(mmc));
that looks better, don't you think?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-07 12:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-07 0:42 [PATCH] staging: mt7621-mmc: Add blank line after declaration nicolas
2018-11-07 11:26 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox