[PATCH 0/2] fpga: altera-cvp: clean checkpatch faults

[PATCH 0/2] fpga: altera-cvp: clean checkpatch faults

[capetry.dev]

From: Carlos A Petry <capetry.dev@gmail.com>

Insert missing or malformed SPDX-License-Identifier tag
    WARNING: Missing or malformed SPDX-License-Identifier tag
Fix function definition argument 'struct altera_cvp_conf *'
    WARNING: function definition argument 'struct altera_cvp_conf *'

Run checkpatch and all problem was fixed in the file.
This is my first contribution to the Kernel Project, 
please let me know if something is wrong, thanks.

Carlos A Petry (2):
  fpga: altera-cvp: Insert SPDX-License-Identifier
  fpga: altera-cvp: Fix function definition argument

 drivers/fpga/altera-cvp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.17.1

[PATCH 1/2] fpga: altera-cvp: Insert SPDX-License-Identifier

[capetry.dev]

From: Carlos A Petry <capetry.dev@gmail.com>

Fix the following checkpatch warning:

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Signed-off-by: Carlos A Petry <capetry.dev@gmail.com>

---
 drivers/fpga/altera-cvp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
index 610a1558e..45b7c8c0b 100644
--- a/drivers/fpga/altera-cvp.c
+++ b/drivers/fpga/altera-cvp.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * FPGA Manager Driver for Altera Arria/Cyclone/Stratix CvP
  *
-- 
2.17.1

Re: [PATCH 1/2] fpga: altera-cvp: Insert SPDX-License-Identifier

[Anatolij Gustschin]

On Wed,  7 Nov 2018 23:13:11 -0200
capetry.dev@gmail.com capetry.dev@gmail.com wrote:
...
>diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
>index 610a1558e..45b7c8c0b 100644
>--- a/drivers/fpga/altera-cvp.c
>+++ b/drivers/fpga/altera-cvp.c
>@@ -1,3 +1,4 @@
>+// SPDX-License-Identifier: GPL-2.0

when SPDX identifier is in place, shouldn't the GPL boilerplate below
be removed?

Anatolij

[PATCH 2/2] fpga: altera-cvp: Fix function definition argument

[capetry.dev]

From: Carlos A Petry <capetry.dev@gmail.com>

Fix the following checkpatch warning:
WARNING: function definition argument 'struct altera_cvp_conf *'

Signed-off-by: Carlos A Petry <capetry.dev@gmail.com>

---
 drivers/fpga/altera-cvp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
index 45b7c8c0b..150a9f5dd 100644
--- a/drivers/fpga/altera-cvp.c
+++ b/drivers/fpga/altera-cvp.c
@@ -66,7 +66,8 @@ struct altera_cvp_conf {
 	struct fpga_manager	*mgr;
 	struct pci_dev		*pci_dev;
 	void __iomem		*map;
-	void			(*write_data)(struct altera_cvp_conf *, u32);
+	void			(*write_data)(struct altera_cvp_conf *conf,
+					      u32 data);
 	char			mgr_name[64];
 	u8			numclks;
 };
-- 
2.17.1