Re: [PATCH 4.14 07/31] clk: tegra: Add quirk for getting CDEV1/2 clocks on Tegra20

Greg Kroah-Hartman
2018-11-10T15:24:20Z

On Fri, Nov 09, 2018 at 09:32:15PM +0300, Dmitry Osipenko wrote:
> On 09.11.2018 0:52, Greg Kroah-Hartman wrote:
> > 4.14-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > [ Upstream commit 5d797111afe12e488e08432fd9b372fae2cc7e93 ]
> >
> > CDEV1 and CDEV2 clocks are a bit special case, their parent clock is
> > created by the pinctrl driver. It should be possible for clk user to
> > request these clocks before pinctrl driver got probed and hence user will
> > get an orphaned clock. That might be undesirable because user may expect
> > parent clock to be enabled by the child, so let's return -EPROBE_DEFER
> > till parent clock appears.
> >
> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> > Acked-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > ---
>
> [snip]
>
> Hello Greg,
>
> You should either pick up c59487075659 in addition or don't backport
> anything at all. The original problem was gone while we were trying to
> fix it and these commits only helping to ensure that the problem won't
> re-occur, AFAIK it shouldn't be necessary to backport any of these
> patches.

Thanks, I've now just dropped this patch from the 4.14.y queue.

greg k-h