From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A03C43441 for ; Thu, 8 Nov 2018 22:45:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E206320844 for ; Thu, 8 Nov 2018 22:45:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xmV6VQzT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E206320844 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728710AbeKIIXc (ORCPT ); Fri, 9 Nov 2018 03:23:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:59318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728103AbeKIIX0 (ORCPT ); Fri, 9 Nov 2018 03:23:26 -0500 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4CB020840; Thu, 8 Nov 2018 22:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541717143; bh=ammYTnP1U5yudbT4E99Qe6kOdOFJwKSJ/l8bEYSEGSI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xmV6VQzTU/pmZA5llXaVSpWC/SEid6L9uOiX5U0zVCFoLwAIdjYMm2Fgb5Jt88Odr uuA1jhxbjnIK46MRy1HEt6NpDYsMj/goCWeuMZ7584mYKRBQl98iwH8WM/v0vCEsRC gsESOYI3ZDq/z8RJfr/5NRjGxToR4yfQjQjFEv24= Date: Thu, 8 Nov 2018 16:45:41 -0600 From: Bjorn Helgaas To: Christoph Hellwig Cc: Masahiro Yamada , Matt Porter , Alexandre Bounine , Dominik Brodowski , linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 6/9] PCI: consolidate PCI config entry in drivers/pci Message-ID: <20181108224540.GG41183@google.com> References: <20181019120952.32763-1-hch@lst.de> <20181019120952.32763-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181019120952.32763-7-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 19, 2018 at 02:09:49PM +0200, Christoph Hellwig wrote: > There is no good reason to duplicate the PCI menu in every architecture. > Instead provide a selectable HAVE_PCI symbol that indicates availability > of PCI support and the handle the rest in drivers/pci. > > Note that for powerpc we now select HAVE_PCI globally instead of the > convoluted mess of conditional or or non-conditional support per board, > similar to what we do e.g. on x86. For alpha PCI is selected for the > non-jensen configs as it was the default before, and a lot of code does > not compile without PCI enabled. On other architectures with limited > PCI support that wasn't as complicated I've left the selection as-is. > > Signed-off-by: Christoph Hellwig > Acked-by: Max Filippov > Acked-by: Thomas Gleixner > Acked-by: Bjorn Helgaas Sounds like Masahiro plans to take this series and I'm fine with that. Minor typo below, since it sounds like there's another revision coming. > --- a/drivers/pci/Kconfig > +++ b/drivers/pci/Kconfig > @@ -3,6 +3,18 @@ > # PCI configuration > # > > +config HAVE_PCI > + bool > + > +menuconfig PCI > + bool "PCI support" > + depends on HAVE_PCI > + > + help > + This option enables support for the PCI local bus, including > + support for PCI-X and the fundations for PCI Express support. s/fundations/foundations/ > + Say 'Y' here unless you know what you are doing. > + > source "drivers/pci/pcie/Kconfig"