From: Al Viro <viro@ZenIV.linux.org.uk>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Christoph Hellwig <hch@infradead.org>,
David Howells <dhowells@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] sysv: return 'err' instead of 0 in __sysv_write_inode
Date: Sat, 10 Nov 2018 13:03:29 +0000 [thread overview]
Message-ID: <20181110130329.GE32577@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1541823204-45068-1-git-send-email-yuehaibing@huawei.com>
On Sat, Nov 10, 2018 at 04:13:24AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/sysv/inode.c: In function '__sysv_write_inode':
> fs/sysv/inode.c:239:6: warning:
> variable 'err' set but not used [-Wunused-but-set-variable]
>
> __sysv_write_inode should return 'err' instead of 0
>
> Fixes: 05459ca81ac3 ("repair sysv_write_inode(), switch sysv to simple_fsync()")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
prev parent reply other threads:[~2018-11-10 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 4:13 [PATCH -next] sysv: return 'err' instead of 0 in __sysv_write_inode YueHaibing
2018-11-10 8:32 ` Christoph Hellwig
2018-11-10 13:03 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181110130329.GE32577@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox