From: Borislav Petkov <bp@alien8.de>
To: Colin King <colin.king@canonical.com>
Cc: Mark Gross <mark.gross@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Ranganathan Desikan <ravi@jetztechnologies.com>,
"Arvind R ." <arvino55@gmail.com>,
linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC: clean an indentation issues, replace spaces for tabs
Date: Sat, 10 Nov 2018 16:58:51 +0100 [thread overview]
Message-ID: <20181110155851.GC20023@zn.tnic> (raw)
In-Reply-To: <20181109133757.21471-1-colin.king@canonical.com>
On Fri, Nov 09, 2018 at 01:37:57PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to clean up an indentation issues, replacing 7 space chars
> for a tab and also inserting a missing indentation
Pls see section "2) Describe your changes" in
Documentation/process/submitting-patches.rst
about how to formulate your commit message. Especially this:
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to
do frotz", as if you are giving orders to the codebase to change its
behaviour."
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/edac/e752x_edac.c | 4 ++--
> drivers/edac/i3000_edac.c | 4 ++--
> drivers/edac/i5000_edac.c | 4 ++--
> drivers/edac/i7core_edac.c | 2 +-
> drivers/edac/i82975x_edac.c | 4 ++--
> 5 files changed, 9 insertions(+), 9 deletions(-)
Anyway, fixed up and applied,
thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
prev parent reply other threads:[~2018-11-10 16:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 13:37 [PATCH] EDAC: clean an indentation issues, replace spaces for tabs Colin King
2018-11-10 15:58 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181110155851.GC20023@zn.tnic \
--to=bp@alien8.de \
--cc=arvino55@gmail.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.gross@intel.com \
--cc=mchehab@kernel.org \
--cc=ravi@jetztechnologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox